Some comments Re: [PATCH 1/2][Hirsute] UBUNTU: [Packaging] rules -- filter out udebs when not needed

[Kamal Mostafa]

On Tue, Feb 9, 2021 at 5:30 AM Dimitri John Ledkov <xnox at ubuntu.com> wrote:

> On Tue, 9 Feb 2021 at 12:42, Tim Gardner <tim.gardner at canonical.com>
> wrote:
>
> > > +ifeq ($(do_di),true)
> > > +     echo >> debian/control
> >
> > What is the point of this line ^^ ?
> >
>
> So some of the debian.master/control.d/*.stub files do not end with
> '\n\n' hence one cannot append a paragraph of a new package right
> after it, which is what kernel-wedge generates.
> You will notice that the perl script did pre-print '\n' before every
> paragraph it filtered in.
> So alternative to this echo would be to fix the control.d/*.stub files
> to end with double new line at the end.
>
>
Relying on the *.stub files to stay that way seems pretty fragile, so I
think keeping it scripted (as you're doing) is the right approach.  How
about adding a comment documenting the purpose of that blank line echo?

 -Kamal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210209/ba7c4ba7/attachment.html>