ACK/Cmnt: [PATCH 1/1][SRU][FOCAL][RISC-V][5.8] UBUNTU: [Packaging] Use gcc-10 for riscv 5.8 kernel build

[Andrea Righi]

On Sat, Jan 30, 2021 at 10:51:26AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1913864
> 
> 5.8 RISC-V really requires gcc-10 for a bootable build, so
> enable this.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>

Do you think it'd make sense to keep gcc-10 in "Recommends", but when
setting the gcc variable check if the installed version is < 10, and
only in that case redefine gcc=gcc-10?

In this case if (for any reason) gcc > 10 is installed we would use the
new version instead of forcing it to be gcc-10.

In any case:

Acked-by: Andrea Righi <andrea.righi at canonical.com>

> ---
>  debian.master/control.stub.in | 2 +-
>  debian/rules                  | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.master/control.stub.in b/debian.master/control.stub.in
> index 9c1e956092bf..3b920328caff 100644
> --- a/debian.master/control.stub.in
> +++ b/debian.master/control.stub.in
> @@ -68,7 +68,7 @@ Section: devel
>  Priority: optional
>  Provides: linux-source
>  Depends: ${misc:Depends}, binutils, bzip2, coreutils
> -Recommends: libc-dev, gcc, make
> +Recommends: libc-dev, gcc-10, make
>  Suggests: libncurses-dev | ncurses-dev, kernel-package, libqt3-dev
>  Description: Linux kernel source for version PKGVER with Ubuntu patches
>   This package provides the source code for the Linux kernel version
> diff --git a/debian/rules b/debian/rules
> index 627ca3cb968f..425d33b35fde 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -8,6 +8,7 @@
>  #
>  
>  DEBIAN=$(shell awk -F= '($$1 == "DEBIAN") { print $$2 }' <debian/debian.env)
> +gcc=gcc-10
>  
>  # dpkg-buildpackage passes options that are incomptatible
>  # with the kernel build.
> -- 
> 2.29.2
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team