[F/H/I/J/Unstable][OEM-5.10/OEM-5.13/OEM-5.14][SRU][PATCH 0/1] selftests: icmp_redirect: pass xfail=0 to log_test()
Po-Hsu Lin
po-hsu.lin at canonical.com
Tue Dec 28 09:43:50 UTC 2021
[Impact]
If any sub-test in this icmp_redirect.sh is failing but not expected
to fail. The script will complain:
./icmp_redirect.sh: line 72: [: 1: unary operator expected
This is because when the sub-test is not expected to fail, we won't
pass any value for the xfail local variable in log_test() and thus
it's empty. Fix this by passing 0 as the 4th variable to log_test()
for non-xfail cases.
This issue can be found on our KVM kernel with SRU tests, they're
failing because of missing some kernel configs.
[Fix]
* 39d8622c72 "selftests: icmp_redirect: pass xfail=0 to log_test()"
This patch can be cherry-picked into all of the affected kernels.
[Test Plan]
Run the patched icmp_redirect.sh script with a KVM kernel (e.g. F/kvm),
and this "unary operator expected" error message should no longer exist.
[Where problems could occur]
Change limited to test script, it won't have any impact to real kernel
function. And this issue is most likely specific to KVM kernels.
Po-Hsu Lin (1):
selftests: icmp_redirect: pass xfail=0 to log_test()
tools/testing/selftests/net/icmp_redirect.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.7.4
More information about the kernel-team
mailing list