[SRU][J/I/H/F][PATCH 2/2] ipmi: msghandler: Make symbol 'remove_work_wq' static
Ioanna Alifieraki
ioanna-maria.alifieraki at canonical.com
Thu Dec 16 10:21:45 UTC 2021
From: Wei Yongjun <weiyongjun1 at huawei.com>
BugLink: https://bugs.launchpad.net/bugs/1950666
The sparse tool complains as follows:
drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
symbol 'remove_work_wq' was not declared. Should it be static?
This symbol is not used outside of ipmi_msghandler.c, so
marks it static.
Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
Reported-by: Hulk Robot <hulkci at huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
Message-Id: <20211123083618.2366808-1-weiyongjun1 at huawei.com>
Signed-off-by: Corey Minyard <cminyard at mvista.com>
(cherry picked from commit 5a3ba99b62d8486de0316334e72ac620d4b94fdd)
Signed-off-by: Ioanna Alifieraki <ioanna-maria.alifieraki at canonical.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index f3a2f228f648..b404cc46cbda 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -191,7 +191,7 @@ struct ipmi_user {
struct work_struct remove_work;
};
-struct workqueue_struct *remove_work_wq;
+static struct workqueue_struct *remove_work_wq;
static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index)
__acquires(user->release_barrier)
--
2.17.1
More information about the kernel-team
mailing list