APPLIED [OEM-5.14] Re: [PATCH 0/2][SRU][OEM-5.14][U] Fix power button wakeup with shared IRQs on AMD platforms
Timo Aaltonen
tjaalton at ubuntu.com
Mon Dec 13 13:06:16 UTC 2021
On 8.12.2021 23.14, Alex Hung wrote:
> BugLink: https://bugs.launchpad.net/bugs/1953540
>
> [Impact]
> On some platform designs the the power button wakeup from s0i3 doesn't work
> even with the existing changes to IRQ handling for the GPIO controller.
>
> In these designs the ACPI SCI and GPIO controller share an IRQ. Due to the
> way the s2idle loop handles the IRQ for the ACPI SCI the GPIO controller
> driver doesn't get a chance to wake the system in this circumstance.
>
> [Fix]
> To fix this rework the existing IRQ handler function to function as a checker
> and an IRQ handler depending on the calling arguments.
>
> The patches were cherry-picked from 5.16rc3.
>
> [Test]
> This is requested by AMD. The test was done on two systems L15 AMD Gen2 and
> P14s AMD Gen2 and both can be waken up by power button presses.
>
> [Where problems could occur]
> Risk is low. This only affects AMD platforms with s0i3 enabled. Suspends (S3)
> and resumes are not affect.
>
> Mario Limonciello (2):
> ACPI: Add stubs for wakeup handler functions
> pinctrl: amd: Fix wakeups when IRQ is shared with SCI
>
> drivers/pinctrl/pinctrl-amd.c | 29 ++++++++++++++++++++++++++---
> include/linux/acpi.h | 9 +++++++++
> 2 files changed, 35 insertions(+), 3 deletions(-)
>
applied to oem-5.14, thanks
--
t
More information about the kernel-team
mailing list