[SRU][F][PATCH 3/4] KVM: s390: remove diag318 reset code

frank.heimes at canonical.com frank.heimes at canonical.com
Tue Dec 7 20:38:47 UTC 2021


From: Collin Walling <walling at linux.ibm.com>

BugLink: https://bugs.launchpad.net/bugs/1953334

The diag318 data must be set to 0 by VM-wide reset events
triggered by diag308. As such, KVM should not handle
resetting this data via the VCPU ioctls.

Fixes: 23a60f834406 ("s390/kvm: diagnose 0x318 sync and reset")
Signed-off-by: Collin Walling <walling at linux.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger at de.ibm.com>
Reviewed-by: Janosch Frank <frankja at linux.ibm.com>
Acked-by: Cornelia Huck <cohuck at redhat.com>
Signed-off-by: Christian Borntraeger <borntraeger at de.ibm.com>
Link: https://lore.kernel.org/r/20201104181032.109800-1-walling@linux.ibm.com
(backported from commit 6cbf1e960fa52e4c63a6dfa4cda8736375b34ccc)
Signed-off-by: Frank Heimes <frank.heimes at canonical.com>
---
 arch/s390/kvm/kvm-s390.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index a8adbe7ffc89..5dda764fa16b 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -3556,7 +3556,6 @@ static void kvm_arch_vcpu_ioctl_initial_reset(struct kvm_vcpu *vcpu)
 		vcpu->arch.sie_block->pp = 0;
 		vcpu->arch.sie_block->fpf &= ~FPF_BPBC;
 		vcpu->arch.sie_block->todpr = 0;
-		vcpu->arch.sie_block->cpnc = 0;
 	}
 }
 
@@ -3574,7 +3573,6 @@ static void kvm_arch_vcpu_ioctl_clear_reset(struct kvm_vcpu *vcpu)
 
 	regs->etoken = 0;
 	regs->etoken_extension = 0;
-	regs->diag318 = 0;
 }
 
 int kvm_arch_vcpu_ioctl_set_regs(struct kvm_vcpu *vcpu, struct kvm_regs *regs)
-- 
2.25.1




More information about the kernel-team mailing list