NAK: [PATCH 0/41] [Hirsute/linux-azure] Enable arm64

[Krzysztof Kozlowski]

On 04/11/2021 13:54, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1949770
> 
> SRU Justification
> 
> [Impact]
> 
> Microsoft has asked to enable arm64 in Azure 5.11 and subsequent kernels.
> This is a preview which will be used to test arm64 as well as ensure
> that nothing has been broken in x64 land.
> 
> [Test Case]
> 
> Microsoft tested.
> 
> [Where things could go wrong]
> 
> Some of the patches touch common PCI code. Device detection could be impacted.
> 
> [Other Info]
> 
> SF: #00310705
> 
> The following changes since commit 5d3c090ec0e25a272da08305b377a2d2aede0109:
> 
>   UBUNTU: [Config] CONFIG_MICROSOFT_MANA=y (2021-11-02 11:53:39 -0600)
> 
> are available in the Git repository at:
> 
>   git://git.launchpad.net/~timg-tpi/ubuntu/+source/linux/+git/hirsute cranky/azure
> 
> for you to fetch changes up to c2982e17c3704b205a08db13dac5f72ea9cce4b0:
> 
>   UBUNTU: [Packaging] linux-azure: Temporally disable signed image for the arm64 preview kernel (2021-11-04 06:40:27 -0600)
> 

Most of the patches (done by Marcelo) lack your SoB which must be there
to satisfy the chain (your are sending them). It's trivial to add it -
just checkout new branch and cherry-pick entire range with -s.

Also in few patches you add comments after SoB, but these should be
before, so:
[rtg - minor context differences]
Signed-off-by: Tim Gardner <tim.gardner at canonical.com>

Because otherwise someone expects SoB from "rtg" :)

The code look correct, more or less.

Best regards,
Krzysztof