ACK+Cmnt: [SRU][F][PATCH 0/1] Fix build issues in selftest/memfd

[Thadeu Lima de Souza Cascardo]

On Mon, Aug 30, 2021 at 04:11:56PM -0700, Luke Nowakowski-Krijger wrote:
> [Impact]
> BugLink: https://bugs.launchpad.net/bugs/1926142
> 
> There are build issues in selftest/memfd that are leading to regression
> and adt test failures across all B/5.4 and possibly hwe kernels due to
> selftests being built against headers that do not have the newer
> definitions used by the tests.
> 
> [Fix]
> * selftests/memfd: fix build when F_SEAL_FUTURE_WRITE is not defined
> 
> [Test Plan]
> Recompile tests to make sure they build and tests pass.
> 
> [Where problems could occur]
> Unlikely to be any problems because userspace apis should be backwards
> compatiable and the definition we are trying to copy should not be
> changing.
> 
> [Other Info]
> Should not go upstream.

Honestly, I don't see why not. If you look at
tools/testing/selftests/seccomp/seccomp_bpf.c, you will notice a lot of these
definitions.

These tests are supposed to be used with the kernels they are shipped with, and
these kernels do support these features. And they should build on systems with
not as recent system headers as the kernels.

Cascardo.

> 
> Luke Nowakowski-Krijger (1):
>   selftests/memfd: fix build when F_SEAL_FUTURE_WRITE is not defined
> 
>  tools/testing/selftests/memfd/memfd_test.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> -- 
> 2.30.2
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team