ACK: [SRU][Focal][PATCH 0/1] ice: Fix bad register reads

[Tim Gardner]

Acked-by: Tim Gardner <tim.gardner at canonical.com>

On 8/26/21 10:27 AM, Michael Reed wrote:
> From: Michael Reed <Michael.Reed at canonical.com>
> 
> BugLink:  https://launchpad.net/bugs/1939855
> 
> [Impact]
> 
> When we run the command, ethtool -d <interface_name> with Intel cards (ice driver), the kernel crashes because of the ice driver.
> The same works fine with HWE kernel (5.11). Here, we do not see any crash.
> 
> [FIXES]
> 
> ice: Fix bad register reads
> The "ethtool -d" handler reads registers in the ice_regs_dump_list array
> and returns read values back to the userspace.
> 
> commitID: 1fba4a8a92706c89716449b1aab1b6879f438d34
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/ethernet/intel/ice?id=1fba4a8a92706c89716449b1aab1b6879f438d34
> 
> [TESTING]
> 
> Install Focal on a system with an E810 network device.
> Ensure the network device has an IP address and has connectivity
> Run ethtool -d <interface_name>
> Expected result: Prints a register dump for the specified network device
> 
> [REGRESSION RISK]
> 
> The regression risk is low
> 
> [OTHER INFO]
> 
> I have added the fix, built the kernel and tested the fix.
> 
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/e810_ethtool_fix_next
> 
> 
> Anirudh Venkataramanan (1):
>    ice: Fix bad register reads
> 
>   drivers/net/ethernet/intel/ice/ice_ethtool.c    | 3 ---
>   drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 3 ---
>   2 files changed, 6 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc