ACK: [SRU][Hirsute][PATCH 0/2] alsa: the soundwire audio doesn't work on the Dell TGL-H machines

[Tim Gardner]

Acked-by: Tim Gardner <tim.gardner at canonical.com>

On 8/25/21 11:09 PM, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1941669
> 
> These 2 patches were merged to upstream kernel from v5.12, no need to
> send them to impish/oem-5.13/unstable kernels. And this patch is
> already in the oem-5.10 kernel, for focal kernel, since focal kernel
> doesn't support soundwire audio, these 2 patches are useless for focal
> kernel.
> 
> 
> [Impact]
> The Dell precision 5760 is a TGL-H machine, and it has soundwire audio
> design, when running the hirsute kernel, the audio driver fails to
> load sof-firmware, then the whole audio fails to initialize and fails
> to work.
> 
> [Fix]
> Backport 2 patches, these will remove hardcoded firmware name and
> allow load firmware according to the firmware name defined by pciid
> 
> [Test]
> Booting the patched kernel, check dmesg, there is no errors about
> loading audio sof-firmware, playsound to spk and headphone, all worked
> well, record sound from internal mic and external mic, all worked well.
> 
> [Where problems could occur]
> The patch remove the hardcoded firmware for all TGL soundwire machines,
> this could make the TGL soundwire machines fail to load the
> sof-firmware then the whole audio fail to work. But this possibiliy is
> low, since we tested the patches on different TGL soundwire machines,
> all worked well.
> 
> 
> Libin Yang (2):
>    ASoC: SOF: allow soundwire use desc->default_fw_filename
>    ASoC: Intel: tgl: remove sof_fw_filename set for tgl_3_in_1_default
> 
>   sound/soc/intel/common/soc-acpi-intel-tgl-match.c | 7 -------
>   sound/soc/sof/intel/hda.c                         | 5 ++++-
>   2 files changed, 4 insertions(+), 8 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc