ACK: [SRU][F/H][PATCH 0/1] Revert ACPI patch which introduces boot failures

Dimitri John Ledkov dimitri.ledkov at canonical.com
Wed Aug 25 22:21:56 UTC 2021


On Wed, Aug 25, 2021 at 11:19 PM Colin Ian King
<colin.king at canonical.com> wrote:
>
> On 25/08/2021 23:15, Kelsey Skunberg wrote:
> > SRU Justification:
> >
> > BugLink: https://bugs.launchpad.net/bugs/1941657
> >
> > Impact:
> >
> > The commit 0ec4e55e9f57 ("ACPI: resources: Add checks for ACPI IRQ override")
> > introduces regression on some platforms, at least it makes the UART can't get
> > correct irq setting on two different platforms, and it makes the kernel can't
> > bootup on these two platforms.
> >
> > discussion regarding the regression:
> > https://bugzilla.kernel.org/show_bug.cgi?id=213031#c32
> >
> > Fix: Revert "ACPI: resources: Add checks for ACPI IRQ override"
> >
> > Risk: Reverting this patch will keep LP#1909814 ("Keyboard not working")
> > unfixed.  https://launchpad.net/bugs/1909814
> >
> > Hui Wang (1):
> >   Revert "ACPI: resources: Add checks for ACPI IRQ override"
> >
> >  drivers/acpi/resource.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
>
> Seems sensible to me.
>
> Acked-by: Colin Ian King <colin.king at canonical.com>

Damned if we do, damned if we don't. Always better keep existing pet
bugs, than introduce new ones.

Acked-by: Dimitri John Ledkov <dimitri.ledkov at canonical.com>

--
Regards,

Dimitri.



More information about the kernel-team mailing list