ACK/Cmnt: [PATCH 0/1][SRU][OEM-5.13][H][I][U] ath10k: don't fail if IRAM write fails

Tim Gardner tim.gardner at canonical.com
Fri Aug 20 11:50:13 UTC 2021


Acked-by: Tim Gardner <tim.gardner at canonical.com>

I think for Hirsute this could wait until its at least in linux-next.

On 8/20/21 4:51 AM, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1939937
> 
> [Impact]
> 
> Commit 9af7c32ceca8 ("ath10k: add target IRAM recovery feature support")
> in v5.11 fails firmware loading without IRAM recovery feature. However,
> the latest firmware from
> https://github.com/kvalo/ath10k-firmware/tree/master/QCA9984/hw1.0/3.9.0.2
> doesn't support IRAM, it follows new official ath10k firmwares may no
> longer be loadable for kernel newer than v5.11.
> 
> [Fix]
> 
> A fix is proposed to
> http://lists.infradead.org/pipermail/ath10k/2021-July/012729.html that
> turns the lack/failure of IRAM recovery support a warning instead.
> 
> [Test Case]
> 
> With this fix, kernel gives errors about the IRAM supportness, but
> proceeds to remaining procedures as before.
> 
>    ath10k_pci 0000:04:00.0: No hardware memory
>    ath10k_pci 0000:04:00.0: failed to copy target iram contents: -12
>    ath10k_pci 0000:07:00.0: No hardware memory
>    ath10k_pci 0000:07:00.0: failed to copy target iram contents: -12
> 
> [Where problems could occur]
> 
> So the IRAM recovery feature may or may not be supported in the
> officially released firmware, and people meet problems when using
> non-IRAM supported firmware may still have a fallback to use older, but
> IRAM recovery supported ones.
> 
> Slava Kardakov (1):
>    UBUNTU: SAUCE: ath10k: don't fail if IRAM write fails
> 
>   drivers/net/wireless/ath/ath10k/core.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 

-- 
-----------
Tim Gardner
Canonical, Inc



More information about the kernel-team mailing list