ACK+cmnt: [PATCH] Revert "scsi: core: Cap scsi_host cmd_per_lun at can_queue"

Kamal Mostafa kamal at canonical.com
Thu Aug 19 18:35:56 UTC 2021


Acked-by: Kamal Mostafa <kamal at canonical.com>

I think this patch title should be prefaced with "UBUNTU: SAUCE:" since
this revert is Ubuntu-specific.  The commit and code it reverts still exists
in upstream mainline and stables v4.15 and v4.19.

 -Kamal

On Thu, Aug 19, 2021 at 12:21:40PM -0600, Tim Gardner wrote:
> BugLink: https://bugs.launchpad.net/bugs/1940564
> 
> This reverts commit 10b9a1068ba301b6458a308c749eb0b93951010c from a stable update.
> 
> A boot failure in the form of a udevd hang was detected in Azure Standard_D48_v3
> instances. Reverting this commit allows the boot to continue.
> 
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
>  drivers/scsi/hosts.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index ec976b93341cf..20bb5a7dca3cd 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -213,9 +213,6 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev,
>  		goto fail;
>  	}
>  
> -	shost->cmd_per_lun = min_t(short, shost->cmd_per_lun,
> -				   shost->can_queue);
> -
>  	error = scsi_init_sense_cache(shost);
>  	if (error)
>  		goto fail;
> -- 
> 2.33.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list