ACK: [HIRSUTE][linux-riscv][PATCH 0/3] Disable ftrace of all sbi functions

Colin Ian King colin.king at canonical.com
Tue Aug 17 17:46:11 UTC 2021


On 17/08/2021 17:27, Dimitri John Ledkov wrote:
> Cherry-pick upstream patches that correctly disable ftrace of all
> sbi.c functions, thus preventing spurious failure to boot. One cannot
> ftrace functions that are used in ftrace setup.
> 
> This has been fixed in v5.12, did not make into 5.11.x-stable which is
> no longer stable upstream.
> 
> Our previous, incomplete fix, to disable ftrace on just one sbi
> function call is thus no longer needed with these cherrypicks and can
> be reverted, given that all sbi functions have tracing disabled with
> these patches.
> 
> BugLink: https://bugs.launchpad.net/bugs/1934548
> 
> Dimitri John Ledkov (1):
>   Revert "UBUNTU: SAUCE: RISC-V: prevent sbi_send_cpumask_ipi race with
>     ftrace"
> 
> Guo Ren (2):
>   riscv: Fixup wrong ftrace remove cflag
>   riscv: Fixup patch_text panic in ftrace
> 
>  arch/riscv/kernel/Makefile | 5 +++--
>  arch/riscv/kernel/sbi.c    | 2 +-
>  arch/riscv/mm/Makefile     | 3 ++-
>  3 files changed, 6 insertions(+), 4 deletions(-)
> 

Thanks Dimitri, this looks sane to me.  The bug link is missing a SRU
justification and list of risks with this fix. Care to update this?

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the kernel-team mailing list