NACK: [SRU][F:linux-bluefield][PATCH 0/7] Add support for packet-per-second policing

[Tim Gardner]

On 8/9/21 7:23 PM, Jianbo Liu wrote:
> Patch 4 and 6 are all backported from the original upstream ones.
> As the related feature are missing in these drivers, I modified them and try not break functionalities when cherry-pick from upstream.
> So I tagged them as "backported from ...". Is this not correct? What should I do?
> 

Under your Signed-off-by add a section encased in "[...]" that describes 
what you had to do to make the back port apply. For example:

[rtg - this comment describes what changes were made to the upstream patch]

> -----Original Message-----
> From: Tim Gardner <tim.gardner at canonical.com>
> Sent: Monday, August 9, 2021 8:12 PM
> To: Bodong Wang <bodong at nvidia.com>; kernel-team at lists.ubuntu.com
> Cc: Vladimir Sokolovsky <vlad at nvidia.com>; Majd Dibbiny <majd at nvidia.com>; Maor Dickman <maord at nvidia.com>; Jianbo Liu <jianbol at nvidia.com>
> Subject: NACK: [SRU][F:linux-bluefield][PATCH 0/7] Add support for packet-per-second policing
> 
> 
> On 8/3/21 1:16 PM, Bodong Wang wrote:
>> This series adds the support for packet-per-second policing from
>> upstream.
>>
>> This supports adding tc filter rule with police action with packet rates.
>>
>> For example:
>> tc filter add dev enp8s0f0_0 ingress protocol ip flower \
>>      dst_mac b8:ce:f6:7b:d9:24 \
>>      action police pkts_rate 1000 pkts_burst 100 conform-exceed drop/pipe \
>>      action mirred egress redirect dev enp8s0f0
>>
>> Baowen Zheng (2):
>>     flow_offload: reject configuration of packet-per-second policing in
>>       offload drivers
>>     net/sched: act_police: add support for packet-per-second policing
>>
>> Po Liu (3):
>>     net: qos: add tc police offloading action with max frame size limit
>>     net: qos: police action add index for tc flower offloading
>>     net:qos: police action offloading parameter 'burst' change to the
>>       original value
>>
>> Vlad Buslov (1):
>>     net: sched: refactor police action helpers to require tcf_lock
>>
>> Xingfeng Hu (1):
>>     flow_offload: add support for packet-per-second policing
>>
>>    drivers/net/ethernet/mellanox/mlx5/core/en_tc.c    |   4 +
>>    .../net/ethernet/netronome/nfp/flower/qos_conf.c   |  11 ++-
>>    include/net/flow_offload.h                         |   6 +-
>>    include/net/sch_generic.h                          |  14 +++
>>    include/net/tc_act/tc_police.h                     | 100 ++++++++++++++++++++-
>>    include/uapi/linux/pkt_cls.h                       |   2 +
>>    net/sched/act_police.c                             |  59 ++++++++++--
>>    net/sched/cls_api.c                                |   7 +-
>>    net/sched/sch_generic.c                            |  75 ++++++++++------
>>    9 files changed, 237 insertions(+), 41 deletions(-)
>>
> 
> Patch 4 (net:qos: police action offloading parameter 'burst' change to
> the original value) deserves some explanation of the backport. There is
> a lot of carnage happening there. These are the files left unpatched
> after the attempted cherry-pick.
> 
> 	deleted by us:   drivers/net/dsa/ocelot/felix.c
> 	deleted by us:   drivers/net/dsa/sja1105/sja1105_flower.c
> 	both modified:   drivers/net/dsa/sja1105/sja1105_main.c
> 	deleted by us:   drivers/net/ethernet/freescale/enetc/enetc_qos.c
> 	both modified:   drivers/net/ethernet/mscc/ocelot_flower.c
> 	deleted by us:   drivers/net/ethernet/mscc/ocelot_net.c
> 	both modified:   include/net/dsa.h
> 
> rtg
> 
> -----------
> Tim Gardner
> Canonical, Inc
> 

-- 
-----------
Tim Gardner
Canonical, Inc