[PATCH 1/1][SRU][H/I] UBUNTU: [Config] set CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC to y

[Chris Chiu]

On Mon, Aug 9, 2021 at 6:01 PM Kleber Souza <kleber.souza at canonical.com> wrote:
>
> On 27.07.21 12:41, Kleber Souza wrote:
> > On 26.07.21 17:54, chris.chiu at canonical.com wrote:
> >> From: Chris Chiu <chris.chiu at canonical.com>
> >>
> >> BugLink: https://bugs.launchpad.net/bugs/1915117
> >>
> >> Enable CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC for Intel Skylake
> >> SST with HDA DSP generic machine driver to enable codec playback and
> >> capture on both HDA codec and DMIC port.
> >>
> >> Signed-off-by: Chris Chiu <chris.chiu at canonical.com>
> >> ---
> >>    debian.master/config/annotations          | 3 +--
> >>    debian.master/config/config.common.ubuntu | 2 +-
> >>    2 files changed, 2 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> >> index 2c4136229a53..0e1b74ac6791 100644
> >> --- a/debian.master/config/annotations
> >> +++ b/debian.master/config/annotations
> >> @@ -8733,14 +8733,13 @@ CONFIG_SND_SOC_INTEL_CNL                        policy<{'amd64': 'n'}>
> >>    CONFIG_SND_SOC_INTEL_CFL                        policy<{'amd64': 'n'}>
> >>    CONFIG_SND_SOC_INTEL_CML_H                      policy<{'amd64': 'n'}>
> >>    CONFIG_SND_SOC_INTEL_CML_LP                     policy<{'amd64': 'n'}>
> >> -CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC      policy<{'amd64': 'n'}>
> >> +CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC      policy<{'amd64': 'y'}>
> >>    #
> >>    CONFIG_SND_SOC_INTEL_SKYLAKE                    mark<ENFORCED> note<deprecated>
> >>    CONFIG_SND_SOC_INTEL_CNL                        mark<ENFORCED> note<deprecated>
> >>    CONFIG_SND_SOC_INTEL_CFL                        mark<ENFORCED> note<deprecated>
> >>    CONFIG_SND_SOC_INTEL_CML_H                      mark<ENFORCED> note<deprecated>
> >>    CONFIG_SND_SOC_INTEL_CML_LP                     mark<ENFORCED> note<deprecated>
> >> -CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC      mark<ENFORCED> note<deprecated>
> >
> > Should we still keep it as enforced to make sure this won't regress again?
> > In that case we can add a reference to the LP bug number instead of removing
> > the enforcement.
>
> Hi Chris,
>
> Any feedback about my suggestion on keeping the enforcement?
>
>
> Kleber
>

Sorry that I forgot to update here. I proposed a v2
https://lists.ubuntu.com/archives/kernel-team/2021-July/122771.html
according to your suggestion. Could you help review? Thanks

Chris

> >
> >
> > Kleber
> >
> >
> >>
> >>    # Menu: Device Drivers >> Sound card support >> Advanced Linux Sound Architecture >> ALSA for SoC audio support >> Intel ASoC SST drivers >> Intel Machine drivers
> >>    CONFIG_SND_SOC_INTEL_MACH                       policy<{'amd64': 'y'}>
> >> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> >> index 5dabbce93cae..dd16b39e481f 100644
> >> --- a/debian.master/config/config.common.ubuntu
> >> +++ b/debian.master/config/config.common.ubuntu
> >> @@ -10016,7 +10016,7 @@ CONFIG_SND_SOC_INTEL_SKL_RT286_MACH=m
> >>    # CONFIG_SND_SOC_INTEL_SKYLAKE is not set
> >>    CONFIG_SND_SOC_INTEL_SKYLAKE_COMMON=m
> >>    CONFIG_SND_SOC_INTEL_SKYLAKE_FAMILY=m
> >> -# CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC is not set
> >> +CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=y
> >>    CONFIG_SND_SOC_INTEL_SKYLAKE_SSP_CLK=m
> >>    CONFIG_SND_SOC_INTEL_SOF_CML_RT1011_RT5682_MACH=m
> >>    CONFIG_SND_SOC_INTEL_SOF_DA7219_MAX98373_MACH=m
> >>
> >
>