ACK: [PATCH 0/1][SRU][H] Fix this missing NIC after resume
stefan.bader at canonical.com
Wed Aug 4 07:52:20 UTC 2021
On 15.07.21 15:20, chris.chiu at canonical.com wrote:
> From: Chris Chiu <chris.chiu at canonical.com>
> BugLink: https://bugs.launchpad.net/bugs/1931301
> [SRU Justification]
> The network card will be unavailable after system resume if the interface is not UP before suspend.
> It's because we added the WOL support for this driver. The driver with WoL feature does detach the network interface even the interface is DOWN. However, it doesn't attach the network interface back on resume if it was DOWN. That's why it's unavailable after resume. Fix this by correctly netif_device_attach according to the interface status.
> [Test Case]
> 1. Plug the ethernet cable to the Atheros E220x ethernet adapter
> 2. Suspend the system and check if the ethernet interface available after resume
> 3. Unplug the ethernet cable
> 4. Suspend the system and check if the ethernet interface available after resume
> [Regression Potential]
> Low. The driver code would be identical to working Groovy version after fix.
> Chris Chiu (1):
> UBUNTU: SAUCE: Revert "ethernet: alx: fix order of calls on resume"
> drivers/net/ethernet/atheros/alx/main.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: OpenPGP digital signature
More information about the kernel-team