ACK/Cmnt: [SRU v3][F:linux-bluefield][Pull Request] Cherry-pick the upstreamed mlxbf-gige driver

Stefan Bader stefan.bader at canonical.com
Tue Aug 3 07:29:29 UTC 2021


On 15.07.21 00:44, Asmaa Mnebhi wrote:
> This pull request (27 commits) includes reverting all mlxbf-gige changes in linux-bluefield (21 commits).
> Then it cherry-picks the newly upstreamed version of the mlxbf-gige driver (1 commit).
> It also adds:
> * 1 commit which adds the mlxbf-gige driver version
> * 1 commit which adds the ethtool mlxbf_gige_set_ringparam function
> * 1 commit which cleans up to the gpio-mlxbf2.c. During this cleanup
> process, internal init functions are replaced by the more generic
> gpio_irq_chip struct to be compliant with opensource.
> * 1 commit which removes the phy interrupt from the gpio-mlxbf2.c since the mlxbf-gige driver is no longer dependent on it.
> * 1 commit which fixes setting the gpio direction as output.
> 
> BugLink: https://bugs.launchpad.net/bugs/1934923
> 
> The pull request page can be found at:
> 
> https://code.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield/+git/version-seeds/+merge/405646
> 
> Git repo can be found at:
> 
> git://git.launchpad.net/~asmaam/ubuntu/+source/linux-bluefield master-next
> 
> for you to fetch changes starting from commit cfabdc1ef2b73553a7ecc5908902cbaf290f4f4b
> 
>      Revert "UBUNTU: SAUCE: mlxbf_gige: syncup with v1.23 content"
> 
> Signed-off-by: David Thompson <davthompson at nvidia.com>
> Signed-off-by: Asmaa Mnebhi <asmaa at nvidia.com>
> 
> Asmaa Mnebhi (26):
>    Revert "UBUNTU: SAUCE: mlxbf_gige: syncup with v1.23 content"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: syncup with v1.21 content"
>    Revert "UBUNTU: SAUCE: Automate soft reset of BlueField ARM via GPIO7"
>    Revert "UBUNTU: SAUCE: Syncup with the latest gpio-mlxbf2 and
>      mlxbf-gige drivers"
>    Revert "Revert "UBUNTU: SAUCE: Fix intermittent OOB link up issue""
>    Revert "UBUNTU: SAUCE: Fix intermittent OOB link up issue"
>    Revert "UBUNTU: SAUCE: mlxbf_gige_mdio.c: Support PHY interrupt on
>      Bluesphere"
>    Revert "UBUNTU: SAUCE: mlxbf_gige_main.c: Fix OOB PHY interrupt"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: use streaming DMA mapping for
>      packet buffers"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: address upstream comments on RX and
>      TX"
>    Revert "UBUNTU: SAUCE: mlxbf-gige: remove gpio interrupt coalesce
>      resources"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: add support for ndo_get_stats64"
>    Revert "UBUNTU: SAUCE: mlxbf_gige: address some general upstream
>      comments"
>    Revert "UBUNTU: SAUCE: Address upstream comments from patch v6 for PHY
>      driver"
>    Revert "UBUNTU: SAUCE: mlxbf-gige: cleanups from review"
>    Revert "UBUNTU: SAUCE: mlxbf-gige: v5 patch cleanup and napi_schedule"
>    Revert "UBUNTU: SAUCE: mlxbf_gige_main.c: Fix OOB's ethtool command"
>    Revert "UBUNTU: SAUCE: mlxbf_gige_main.c: Support ethtool options"
>    Revert "UBUNTU: SAUCE: mlxbf-gige: multiple fixes for stability"
>    Revert "UBUNTU: SAUCE: Remove built-in tests from mlxbf_gige driver"
>    Revert "UBUNTU: SAUCE: Add Mellanox BlueField Gigabit Ethernet driver"
>    UBUNTU: SAUCE: mlxbf-gige: add driver version
>    UBUNTU: SAUCE: mlxbf-gige: add ethtool mlxbf_gige_set_ringparam
>    UBUNTU: SAUCE: gpio-mlxbf2: Cleanup and use generic gpio_irq_chip
>      struct
>    UBUNTU: SAUCE: gpio-mlxbf2.c: remove phy interrupt
>    UBUNTU: SAUCE: gpio-mlxbf2.c: Fix setting the gpio direction to output
> 
> David Thompson (1):
>    Add Mellanox BlueField Gigabit Ethernet driver
> 
>   drivers/gpio/gpio-mlxbf2.c                    |  42 +---
>   .../net/ethernet/mellanox/mlxbf_gige/Kconfig  |   2 +-
>   .../net/ethernet/mellanox/mlxbf_gige/Makefile |  10 +-
>   .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h |  20 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  |  11 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c     | 212 ++++++++++++++++++
>   .../mellanox/mlxbf_gige/mlxbf_gige_intr.c     |   3 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_main.c     |  72 +++---
>   .../mellanox/mlxbf_gige/mlxbf_gige_mdio.c     |   2 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     |   2 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_rx.c       |   8 +-
>   .../mellanox/mlxbf_gige/mlxbf_gige_tx.c       |   5 +-
>   12 files changed, 284 insertions(+), 105 deletions(-)
>   create mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c
> ACKC
The start SHA1 seems incorrect but using
  33a8674bc33dda791e7fefb6a83822959c3d6960
seems to result in the right selection.

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210803/0d4188bd/attachment.sig>


More information about the kernel-team mailing list