ACK: [PATCH] hv_netvsc: remove ndo_poll_controller

Krzysztof Kozlowski krzysztof.kozlowski at canonical.com
Fri Apr 30 13:04:25 UTC 2021


On 30/04/2021 14:34, Tim Gardner wrote:
> From: Stephen Hemminger <stephen at networkplumber.org>
> 
> BugLink: https://bugs.launchpad.net/bugs/1924314
> 
> Similar to other patches from ERic.
> 
> As diagnosed by Song Liu, ndo_poll_controller() can
> be very dangerous on loaded hosts, since the cpu
> calling ndo_poll_controller() might steal all NAPI
> contexts (for all RX/TX queues of the NIC). This capture
> can last for unlimited amount of time, since one
> cpu is generally not able to drain all the queues under load.
> 
> In netvsc driver it uses NAPI for TX completions. The default
> poll_napi will do this for us now and avoid the capture.
> 
> Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com>
> Cc: Haiyang Zhang <haiyangz at microsoft.com>
> Cc: Eric Dumazet <edumazet at google.com>
> Reviewed-by: Haiyang Zhang <haiyangz at microsoft.com>
> Signed-off-by: David S. Miller <davem at davemloft.net>
> (backported from commit 2a7f8c3b1d3feedee3aa319ac220cbde3725b5d5)
> [rtg - minor context adjustment]
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---
>  drivers/net/hyperv/netvsc_drv.c | 23 -----------------------
>  1 file changed, 23 deletions(-)


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>


Best regards,
Krzysztof



More information about the kernel-team mailing list