ACK: [SRU][Groovy][PATCH 0/2] Revert tty changes to fix regression

Krzysztof Kozlowski krzysztof.kozlowski at canonical.com
Wed Apr 21 17:58:03 UTC 2021


On 21/04/2021 19:16, Kleber Sacilotto de Souza wrote:
> BugLink: https://bugs.launchpad.net/bugs/1925290
> 
> [Impact]
> Testcase hangup01 from ubuntu_ltp_stable.pty is failing on Groovy 5.8.0-51.57.
> 
> Test case failed with:
>  hangup01 1 TFAIL : hangup01.c:132: unexpected message 3
>  tag=hangup01 stime=1618856629 dur=1 exit=exited stat=1
> 
> It was found that the regression was introduced by the following commits applied
> via stable uddates:
> 
> dd78b0c483e3 tty: implement read_iter
> 3b830a9c34d5 tty: convert tty_ldisc_ops 'read()' function to take a kernel pointer
> 
> These patches were applied via bug 1921960 ("Groovy update: upstream stable
> patchset 2021-03-30").

These should be never part of v5.8 (first patch fixes bug in v5.10,
second lacked clear reason why it was backported to v5.10)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>


Best regards,
Krzysztof



More information about the kernel-team mailing list