[Unstable][PATCH] UBUNTU: [Packaging] Add module versions to the ABI

[Juerg Haefliger]

On Tue, 20 Apr 2021 09:14:45 +0200
Stefan Bader <stefan.bader at canonical.com> wrote:

> On 19.04.21 22:25, Seth Forshee wrote:
> > On Tue, Apr 13, 2021 at 02:36:38PM +0200, Juerg Haefliger wrote:  
> >> Add module versions to the ABI (or '-' if the module doesn't report a
> >> version) and make sure the module check only looks at the module name
> >> and ignores the trailing version.
> >>
> >> This info ends up in the buildinfo package which can be used by meta
> >> packages so that they don't have to build-depend on the huge modules
> >> package to determine versions of in-tree DKMS modules.
> >>
> >> Signed-off-by: Juerg Haefliger <juergh at canonical.com>  
> > 
> > This doesn't seem like a very extensible way of doing things if we ever
> > need to add additional information from modinfo later. We're already
> > inclding the firmware information separately in the fwinfo file. I
> > wonder how much it would bloat the abi size to include all of the
> > modinfo data, similar to what's in modules.builtin.modinfo already
> > (which we would probably also want to pull in as part of this
> > information). It could probably replace the fwinfo and flavour.modules
> > files though as they would now contain redundant information.  
> 
> 
> I am not sure I understand the relation between fwinfo and <flavour>.modinfo. 
> The former to my knowledge is just a list list of all firmware files that are 
> included in the kernel binary.

It's a list of fw blobs our modules want to load.


> I must admit I cannot remember even what that 
> info is used for.

Probably to figure out if all required fw blobs are provided by
linux-firmware.


> The *.modinfo files list modules and related info. Actually right now, only 
> lists module names. And adding a version field is extending this. With <space> 
> as separator between fields, we could have other separators within those.
> What I think is a good idea is to think about adding info for builtin modules.

Yes. Good point.

 
> That would at least get rid of the additional tweaking when making a module a 
> builtin (right now it vanishes from the abi perspective).

I'm leaning towards Seth's idea of 'simply' adding all info from modinfo to
the ABI for both 'real' and built-in modules.

...Juerg


> -Stefan
> > 
> > Seth
> >   
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210420/1df695a6/attachment.sig>