NACK: [PATCH 00/22][SRU][B][linux-firmware] Add missed firmwares claimed by kernel
Seth Forshee
seth.forshee at canonical.com
Thu Apr 15 12:43:14 UTC 2021
On Thu, Apr 15, 2021 at 05:42:26AM -0600, Tim Gardner wrote:
> linux-firmware is already quite large. Are there actual requests for any of
> these missing firmware files ? I'm loathe to add a giant blob because you
> never know where its going. Consider a resource constrained embedded device.
>
> I think I would prefer to add individual firmware files on an as-needed
> basis.
This is actually something we do normally for new hwe kernels. I suspect
most of these files were added subsequent to those updates.
I agree though that without a specific need that going back to every
release and adding all the missing files for every supported kernel
without a demonstrated need seems like overkill. When You-Sheng
originally asked me about doing this I thought he was only planning to
do it for focal:oem-5.10, which I agreed to (and had actually suggested
needed to be done previously).
You-Sheng, I'm sorry if there was a misunderstanding. If we are missing
files for oem-5.10, I'm agreeable to adding those files to focal because
I don't think it was ever done completely in the first place. But I
think we should refrain from blindly adding new firmware files into
older releases because these new files do sometimes cause problems for
users.
Thanks,
Seth
>
> rtg
>
> On 4/13/21 5:41 AM, You-Sheng Yang wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1922350
> >
> > [Impact]
> >
> > Some kernel firmwares might be landed after linux-firmware forked for
> > each series, or for LTS series, kernels of new versions may claim
> > additional ones that were not previously available. This leaves devices
> > fail to function correctly while they ought to.
> >
> > With a checking script that enumerates all the blobs available in
> > upstream repo and in the Ubuntu fork of a given series, e.g. hirsute,
> > iterate through all the installed kernel modules of a given version to
> > check if claimed firmware blobs are available in Ubuntu's fork.
> > Following kernel version/series have been checked:
> >
> > * 4.15.0-140-generic/bionic
> > * 4.18.0-25-generic/bionic
> > * 5.0.0-65-generic/bionic
> > * 5.4.0-70-generic/bionic
> >
> > And it gives following files were missing:
> >
> > * amdgpu/renoir_asd.bin
> > * amdgpu/renoir_ce.bin
> > * amdgpu/renoir_gpu_info.bin
> > * amdgpu/renoir_me.bin
> > * amdgpu/renoir_mec.bin
> > * amdgpu/renoir_mec2.bin
> > * amdgpu/renoir_pfp.bin
> > * amdgpu/renoir_rlc.bin
> > * amdgpu/renoir_sdma.bin
> > * amdgpu/renoir_vcn.bin
> > * amdgpu/vega20_ta.bin
> > * cmmb_vega_12mhz.inp
> > * cmmb_venice_12mhz.inp
> > * dvb_nova_12mhz.inp
> > * dvb_nova_12mhz_b0.inp
> > * i915/bxt_guc_33.0.0.bin
> > * i915/glk_guc_33.0.0.bin
> > * i915/icl_guc_33.0.0.bin
> > * i915/kbl_guc_33.0.0.bin
> > * i915/skl_guc_33.0.0.bin
> > * i915/tgl_dmc_ver2_04.bin
> > * isdbt_nova_12mhz.inp
> > * isdbt_nova_12mhz_b0.inp
> > * isdbt_rio.inp
> > * iwlwifi-Qu-b0-jf-b0-50.ucode
> > * iwlwifi-Qu-c0-hr-b0-50.ucode
> > * iwlwifi-QuZ-a0-hr-b0-50.ucode
> > * iwlwifi-QuZ-a0-jf-b0-50.ucode
> > * iwlwifi-cc-a0-50.ucode
> > * mediatek/mt7663pr2h.bin
> > * mellanox/mlxsw_spectrum-13.2000.1886.mfa2
> > * mrvl/sdsd8977_combo_v2.bin
> > * mrvl/sdsd8997_combo_v4.bin
> > * rtl_nic/rtl8125a-3.fw
> > * rtl_nic/rtl8168fp-3.fw
> > * rtw88/rtw8822c_wow_fw.bin
> > * sms1xxx-hcw-55xxx-dvbt-02.fw
> > * sms1xxx-hcw-55xxx-isdbt-02.fw
> > * sms1xxx-nova-a-dvbt-01.fw
> > * sms1xxx-nova-b-dvbt-01.fw
> > * sms1xxx-stellar-dvbt-01.fw
> > * tdmb_nova_12mhz.inp
> >
> > [Fix]
> >
> > * 2542ba7a amdgpu: update renoir firmware for 20.50
> > * 7c81cc27 amdgpu: update renoir firmware for 20.45
> > * 65370dba rtw88: RTL8822C: Update firmware to v9.9.4
> > - SKIPPED: rtw88/rtw8822c_fw.bin is of a older version
> > * e371b7cd Revert "rtw88: RTL8822C: Update firmware to v9.9.4"
> > - SKIPPED: rtw88/rtw8822c_fw.bin is of a older version
> > * c93834e1 rtw88: RTL8822C: Update firmware to v9.9.4
> > - SKIPPED: rtw88/rtw8822c_fw.bin is of a older version
> > * 9f46d48e amdgpu: update renoir firmware for 20.40
> > * c331aa9c amdgpu: update vega20 firmware for 20.30
> > - SKIPPED: other vega20 firmware blobs are of a older version
> > * d89e9b1a amdgpu: update renoir firmware for 20.30
> > * 9bc37890 linux-firmware: update NXP SDSD-8997 firmware image
> > * f39b6872 Update binary firmware for MT7663 based devices to include firmware offload feature and low power feature.
> > * e96c1212 amdgpu: update renoir firmware from 20.20 release
> > * f73f82cd amdgpu: add vega20 TA firmware from 20.20 release
> > - SKIPPED: other vega20 firmware blobs are of a older version
> > * c2e313be rtw88: RTL8822C: update firmware version to v9.9
> > - SKIPPED: rtw88/rtw8822c_fw.bin is of a older version
> > * 2ae99744 iwlwifi: update FWs to core47-142 release
> > - SKIPPED: this updates existing firmware blobs
> > * 9a0b0f49 amdgpu: update renoir firmware for 20.10
> > * 236ec455 linux-firmware: add firmware for MT7663 Wifi/BT combo device
> > * 6d9f3991 amdgpu: add renoir firmware for 19.50
> > * e8a0f4c9 rtl_nic: add firmware rtl8168fp-3
> > * e4ea25f5 drm/i915/firmware: Add v2.04 of DMC for TGL
> > * f667c005 rtl_nic: add firmware rtl8125a-3
> > * ebd40c66 Mellanox: Add new mlxsw_spectrum firmware 13.2000.1886
> > * 7e431c5d rtw88: RTL8822C: add WoW firmware v7.3
> > - SKIPPED: rtw88/rtw8822c_fw.bin is of a older version
> > * 05dbae66 drm/i915/firmware: Add v33 of GuC for ICL
> > * 786f17a3 drm/i915/firmware: Add v33 of GuC for KBL
> > * aae0eb58 drm/i915/firmware: Add v33 of GuC for SKL
> > * 9cf240f6 drm/i915/firmware: Add v33 of GuC for GLK
> > * 8a0a6a64 drm/i915/firmware: Add v33 of GuC for BXT
> > * 2206320b linux-firmware: add Marvell SD8977 firmware image
> > * 52b23a93 linux-firmware: add Marvell SD8997 firmware image
> > * d2adbb0b linux-firmware: Add firmware files for Siano DTV devices
> > - SKIPPED: this commit was explicitly reverted in LP: #1401711
> >
> > [Test Case]
> >
> > * The same script is used to make sure as many blobs are installed as
> > possible.
> > * Also make sure only blob addition were made. No existing blob touched.
> >
> > [Where problems could occur]
> >
> > While this is to backport firmwares claimed by current kernel drivers,
> > devices previously failed to be successfully initialized due to the lack
> > of corresponding firmware will then be enabled. This may introduce new
> > issues carried by those devices.
> >
> > Alex Deucher (7):
> > amdgpu: add renoir firmware for 19.50
> > amdgpu: update renoir firmware for 20.10
> > amdgpu: update renoir firmware from 20.20 release
> > amdgpu: update renoir firmware for 20.30
> > amdgpu: update renoir firmware for 20.40
> > amdgpu: update renoir firmware for 20.45
> > amdgpu: update renoir firmware for 20.50
> >
> > Anusha Srivatsa (6):
> > drm/i915/firmware: Add v33 of GuC for BXT
> > drm/i915/firmware: Add v33 of GuC for GLK
> > drm/i915/firmware: Add v33 of GuC for SKL
> > drm/i915/firmware: Add v33 of GuC for KBL
> > drm/i915/firmware: Add v33 of GuC for ICL
> > drm/i915/firmware: Add v2.04 of DMC for TGL
> >
> > Ganapathi Bhat (4):
> > linux-firmware: add Marvell SD8997 firmware image
> > linux-firmware: add Marvell SD8997 firmware image
> > linux-firmware: add Marvell SD8977 firmware image
> > linux-firmware: update NXP SDSD-8997 firmware image
> >
> > Heiner Kallweit (2):
> > rtl_nic: add firmware rtl8125a-3
> > rtl_nic: add firmware rtl8168fp-3
> >
> > Ido Schimmel (1):
> > Mellanox: Add new mlxsw_spectrum firmware 13.2000.1886
> >
> > Sean Wang (2):
> > linux-firmware: add firmware for MT7663 Wifi/BT combo device
> > Update binary firmware for MT7663 based devices to include firmware
> > offload feature and low power feature.
> >
> > WHENCE | 59 ++++++++++++++++++++++
> > amdgpu/renoir_asd.bin | Bin 0 -> 180736 bytes
> > amdgpu/renoir_ce.bin | Bin 0 -> 9344 bytes
> > amdgpu/renoir_dmcub.bin | Bin 0 -> 118920 bytes
> > amdgpu/renoir_gpu_info.bin | Bin 0 -> 316 bytes
> > amdgpu/renoir_me.bin | Bin 0 -> 17536 bytes
> > amdgpu/renoir_mec.bin | Bin 0 -> 268048 bytes
> > amdgpu/renoir_mec2.bin | Bin 0 -> 268048 bytes
> > amdgpu/renoir_pfp.bin | Bin 0 -> 21632 bytes
> > amdgpu/renoir_rlc.bin | Bin 0 -> 38904 bytes
> > amdgpu/renoir_sdma.bin | Bin 0 -> 17408 bytes
> > amdgpu/renoir_ta.bin | Bin 0 -> 33536 bytes
> > amdgpu/renoir_vcn.bin | Bin 0 -> 457856 bytes
> > i915/bxt_guc_33.0.0.bin | Bin 0 -> 181888 bytes
> > i915/glk_guc_33.0.0.bin | Bin 0 -> 182336 bytes
> > i915/icl_guc_33.0.0.bin | Bin 0 -> 385280 bytes
> > i915/kbl_guc_33.0.0.bin | Bin 0 -> 182912 bytes
> > i915/skl_guc_33.0.0.bin | Bin 0 -> 182080 bytes
> > i915/tgl_dmc_ver2_04.bin | Bin 0 -> 18436 bytes
> > mediatek/mt7663_n9_v3.bin | Bin 0 -> 441688 bytes
> > mediatek/mt7663pr2h.bin | Bin 0 -> 278558 bytes
> > mellanox/mlxsw_spectrum-13.2000.1886.mfa2 | Bin 0 -> 1015156 bytes
> > mrvl/sdsd8977_combo_v2.bin | Bin 0 -> 587052 bytes
> > mrvl/sdsd8997_combo_v4.bin | Bin 0 -> 623240 bytes
> > rtl_nic/rtl8125a-3.fw | Bin 0 -> 3456 bytes
> > rtl_nic/rtl8168fp-3.fw | Bin 0 -> 336 bytes
> > 26 files changed, 59 insertions(+)
> > create mode 100644 amdgpu/renoir_asd.bin
> > create mode 100644 amdgpu/renoir_ce.bin
> > create mode 100644 amdgpu/renoir_dmcub.bin
> > create mode 100644 amdgpu/renoir_gpu_info.bin
> > create mode 100644 amdgpu/renoir_me.bin
> > create mode 100644 amdgpu/renoir_mec.bin
> > create mode 100644 amdgpu/renoir_mec2.bin
> > create mode 100644 amdgpu/renoir_pfp.bin
> > create mode 100644 amdgpu/renoir_rlc.bin
> > create mode 100644 amdgpu/renoir_sdma.bin
> > create mode 100644 amdgpu/renoir_ta.bin
> > create mode 100644 amdgpu/renoir_vcn.bin
> > create mode 100644 i915/bxt_guc_33.0.0.bin
> > create mode 100644 i915/glk_guc_33.0.0.bin
> > create mode 100644 i915/icl_guc_33.0.0.bin
> > create mode 100644 i915/kbl_guc_33.0.0.bin
> > create mode 100644 i915/skl_guc_33.0.0.bin
> > create mode 100644 i915/tgl_dmc_ver2_04.bin
> > create mode 100644 mediatek/mt7663_n9_v3.bin
> > create mode 100644 mediatek/mt7663pr2h.bin
> > create mode 100644 mellanox/mlxsw_spectrum-13.2000.1886.mfa2
> > create mode 100755 mrvl/sdsd8977_combo_v2.bin
> > create mode 100644 mrvl/sdsd8997_combo_v4.bin
> > create mode 100644 rtl_nic/rtl8125a-3.fw
> > create mode 100644 rtl_nic/rtl8168fp-3.fw
> >
>
> --
> -----------
> Tim Gardner
> Canonical, Inc
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
More information about the kernel-team
mailing list