ACK/Cmnt: [SRU][F:linux-bluefield][PATCH 0/2] reduce memory bloat and aging active ct conns

Stefan Bader stefan.bader at canonical.com
Wed Apr 14 14:01:42 UTC 2021


On 11.04.21 13:45, Roi Dayan wrote:
> BugLink: https://bugs.launchpad.net/bugs/1922678
> 
> 
> SRU Justification:
> 
> The patches are fixing a possible memory hog and aging active ct conns.
> 
> * Explain the bug(s)
> 
> Memory bloat and aging active ct conns can happen from any stress test
> as we have a single workqueue for handling the ct offload conns
> for add/del/stats actions.
> 
> * brief explanation of fixes
> 
> The fix is splitting add/del/stats for diff workqueue and also
> we set a limit for add work entries.
> 
> The first patch is already upstream.
> 
> * How to test
> 
> Testing was done with just stress traffic with lots of conns different 5-tuple.
> 
> * What it could break.
> 
> Can take a lot of memory for a long time and also causing active conns to
> age out when not necessary.
> 
> 
> Oz Shlomo (1):
>    netfilter: flowtable: separate replace, destroy and stats to different
>      workqueues
> 
> Roi Dayan (1):
>    UBUNTU: SAUCE: netfilter: nf_flow_table_offload: Limit work entries on
>      offload add wq
> 
>   net/netfilter/nf_flow_table_offload.c | 56 +++++++++++++++++++++++----
>   1 file changed, 48 insertions(+), 8 deletions(-)
> 
I did update the bug report for this set the way it would be expected (what Tim 
asked to be done for the other two). When doing so I did slightly adjust the 
section about the patches.

Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210414/0ec56d51/attachment.sig>


More information about the kernel-team mailing list