NACK/Cmnt: [PATCH 1/2][Groovy] ALSA: hda/realtek: Add quirk for Intel NUC 10

[Stefan Bader]

On 06.04.21 21:07, Tim Gardner wrote:
> From: Werner Sembach <wse at tuxedocomputers.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1922759
> 
> This adds a new SND_PCI_QUIRK(...) and applies it to the Intel NUC 10
> devices. This fixes the issue of the devices not having audio input and
> output on the headset jack because the kernel does not recognize when
> something is plugged in.
> 
> The new quirk was inspired by the quirk for the Intel NUC 8 devices, but
> it turned out that the NUC 10 uses another pin. This information was
> acquired by black box testing likely pins.
> 
> Co-developed-by: Eckhart Mohr <e.mohr at tuxedocomputers.com>
> Signed-off-by: Eckhart Mohr <e.mohr at tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse at tuxedocomputers.com>
> Cc: <stable at vger.kernel.org>
> Link: https://lore.kernel.org/r/20210302180414.23194-1-wse@tuxedocomputers.com
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> (cherry picked from commit 73e7161eab5dee98114987239ec9c87fe8034ddb)
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> ---

This appears to be a partial v0 which was replaced by a v1 and v2 later on...

-Stefan
>   sound/pci/hda/patch_realtek.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index c264d95266f6..b8059f38dc7b 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6403,6 +6403,7 @@ enum {
>   	ALC269_FIXUP_LEMOTE_A1802,
>   	ALC269_FIXUP_LEMOTE_A190X,
>   	ALC256_FIXUP_INTEL_NUC8_RUGGED,
> +	ALC256_FIXUP_INTEL_NUC10,
>   	ALC255_FIXUP_XIAOMI_HEADSET_MIC,
>   	ALC274_FIXUP_HP_MIC,
>   	ALC274_FIXUP_HP_HEADSET_MIC,
> @@ -7793,6 +7794,15 @@ static const struct hda_fixup alc269_fixups[] = {
>   		.chained = true,
>   		.chain_id = ALC269_FIXUP_HEADSET_MODE
>   	},
> +	[ALC256_FIXUP_INTEL_NUC10] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */
> +			{ }
> +		},
> +		.chained = true,
> +		.chain_id = ALC269_FIXUP_HEADSET_MODE
> +	},
>   	[ALC255_FIXUP_XIAOMI_HEADSET_MIC] = {
>   		.type = HDA_FIXUP_VERBS,
>   		.v.verbs = (const struct hda_verb[]) {
> @@ -8236,6 +8246,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x1c06, 0x2013, "Lemote A1802", ALC269_FIXUP_LEMOTE_A1802),
>   	SND_PCI_QUIRK(0x1c06, 0x2015, "Lemote A190X", ALC269_FIXUP_LEMOTE_A190X),
>   	SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED),
> +	SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", ALC256_FIXUP_INTEL_NUC10),
>   
>   #if 0
>   	/* Below is a quirk table taken from the old code.
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20210407/78a8edd7/attachment.sig>