[PATCH 0/4][SRU][Focal] fix ACPI EC initisation failures

Colin Ian King colin.king at canonical.com
Tue Sep 29 22:13:44 UTC 2020


On 28/09/2020 20:14, Alex Hung wrote:
> BugLink: https://bugs.launchpad.net/bugs/1896482
> 
> [Impact]
> 
> The bug causes the EC driver to fail and ACPI events are no longer
> handled by Linux kernel, i.e lid close no longer triggers suspends.
> 
> [Fix]
> 
> Upstream commit 03e9a0e05739cf reworks ec_install_handlers to avoid
> initialisation failures.
> 
> The other three patches are prerequisite to apply 03e9a0e05739cf on
> focal kernel.
> 
> [Test]
> 
> Tested with Lenovo ThinkPad X1 Carbon Gen 8
> 
> [Regression Potential]
> 
> Low. The patches were cherry-picked from mainline kernel (two since 5.5
> and two since 5.7)
> 
> Daniel Drake (2):
>   ACPI: EC: tweak naming in preparation for GpioInt support
>   ACPI: EC: add support for hardware-reduced systems
> 
> Rafael J. Wysocki (2):
>   ACPI: EC: Avoid passing redundant argument to functions
>   ACPI: EC: Consolidate event handler installation code
> 
>  drivers/acpi/ec.c       | 218 +++++++++++++++++++++++++++++++++---------------
>  drivers/acpi/internal.h |   3 +-
>  2 files changed, 154 insertions(+), 67 deletions(-)
> 

Thanks Alex, I read your answers to my follow-up questions and I'm
satisfied to Ack these patches.

Acked-by: Colin Ian King <colin.king at canonical.com>



More information about the kernel-team mailing list