ACK: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/2] Remove NVMe suspend-to-idle workaround

Kleber Souza kleber.souza at canonical.com
Fri Sep 25 11:10:35 UTC 2020


On 25.09.20 09:41, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1897227
> 
> [Impact]
> We already have correct NVMe suspend-to-idle implementation, we can
> remove workaround we carried in Ubuntu kernel.
> 
> [Fix]
> Revert unnecessary no D3 quirks we used as workaround.
> 
> [Test]
> After the revert, both NVMe still use native power saving mechanism as
> intended.
> 
> [Regression Potential]
> Though unlikely, if there is any platform that uses legacy S3 and needs
> to keep the NVMe device in D0 instead of D3, this might have impact on
> that scenario.
> 
> Kai-Heng Feng (2):
>   Revert "UBUTU: SAUCE: pci: prevent Intel NVMe SSDPEKKF from entering
>     D3"
>   Revert "UBUNTU: SAUCE: pci: prevent sk hynix nvme from entering D3"
> 
>  drivers/pci/quirks.c    | 2 --
>  include/linux/pci_ids.h | 2 --
>  2 files changed, 4 deletions(-)
> 

Always good to remove SAUCE quirks/workarounds.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>

Thanks!



More information about the kernel-team mailing list