[PATCH] UBUNTU: SAUCE: ubuntu_fan_smoke_test: workaround docker 'dependency' failure

[Stefan Bader]

On 21.09.20 18:16, Andrea Righi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1896511
> 
> ubuntu_fan_smoke_test is failing with the following error:
> 
> 111. 	09/16 10:14:02 ERROR| utils:0153| [stderr] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
> 112. 	09/16 10:14:02 DEBUG| utils:0153| [stdout] docker pull ubuntu: FAILED (docker pull returned 1)
> 113. 	09/16 10:14:02 ERROR| test:0414| Exception escaping from test:
> 114. 	Traceback (most recent call last):
> 115. 	File "/home/ubuntu/autotest/client/shared/test.py", line 411, in _exec
> 116. 	_call_test_function(self.execute, *p_args, **p_dargs)
> 117. 	File "/home/ubuntu/autotest/client/shared/test.py", line 823, in _call_test_function
> 118. 	return func(*args, **dargs)
> 119. 	File "/home/ubuntu/autotest/client/shared/test.py", line 291, in execute
> 120. 	postprocess_profiled_run, args, dargs)
> 121. 	File "/home/ubuntu/autotest/client/shared/test.py", line 212, in _call_run_once
> 122. 	self.run_once(*args, **dargs)
> 123. 	File "/home/ubuntu/autotest/client/tests/ubuntu_fan_smoke_test/ubuntu_fan_smoke_test.py", line 53, in run_once
> 124. 	self.results = utils.system_output(cmd, retain_output=True)
> 125. 	File "/home/ubuntu/autotest/client/shared/utils.py", line 1267, in system_output
> 126. 	verbose=verbose, args=args).stdout
> 127. 	File "/home/ubuntu/autotest/client/shared/utils.py", line 918, in run
> 128. 	"Command returned non-zero exit status")
> 129. 	CmdError: Command <./ubuntu_fan_smoke_test.sh 10.246.0.0/16> failed, rc=1, Command returned non-zero exit status
> 130. 	* Command:
> 131. 	./ubuntu_fan_smoke_test.sh 10.246.0.0/16
> 132. 	Exit status: 1
> 
> And this message is showing up in the log:
> 
> systemd: Job docker.service/start failed with result 'dependency'.
> 
> Apparently it seems to be a docker issue, as reported here [1]. Fix by
> applying the resolutions steps suggested in this article.
> 
> [1] https://support.plesk.com/hc/en-us/articles/360012448554-Unable-to-start-Docker-service-Dependency-failed-for-Docker-Application-Container-Engine
> 
> Signed-off-by: Andrea Righi <andrea.righi at canonical.com>
> ---
>  ubuntu_fan_smoke_test/ubuntu_fan_smoke_test.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/ubuntu_fan_smoke_test/ubuntu_fan_smoke_test.sh b/ubuntu_fan_smoke_test/ubuntu_fan_smoke_test.sh
> index 74aa5d87..095a922f 100755
> --- a/ubuntu_fan_smoke_test/ubuntu_fan_smoke_test.sh
> +++ b/ubuntu_fan_smoke_test/ubuntu_fan_smoke_test.sh
> @@ -60,6 +60,12 @@ if [ -n "$http_proxy" ]; then
>              ;;
>      esac
>  
> +    mkdir -p /etc/systemd/system/containerd.service.d
> +    touch /etc/systemd/system/containerd.service.d/override.conf
> +    echo -e "[Service]\nExecStartPre=" >> /etc/systemd/system/containerd.service.d/override.conf

That would work until someone already created that config. And with docker that
might happen sooner than later. So I tend to think this should be a little more
bullet-proof. Or did you ensure that adding multiple "Service" stanzas does
work? The touch and append approach seems odd (why not just "echo >".

-Stefan
> +    systemctl daemon-reload
> +    systemctl restart docker.service
> +
>      echo $EOPTS "[Service]\nEnvironment=\"HTTP_PROXY=$http_proxy\"\n" \
>           > /etc/systemd/system/docker.service.d/http-proxy.conf
>      systemctl daemon-reload
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200922/71986fb6/attachment.sig>