NAK[F/Unstable]: [PATCH 0/1][SRU][B][F][Unstable] Stop using get_scalar_status

Seth Forshee seth.forshee at canonical.com
Mon Sep 21 19:50:49 UTC 2020


On Thu, Jul 30, 2020 at 10:35:24AM +0800, AceLan Kao wrote:
> Got it, will check all series and send the patch.

I still haven't seen any updated patch for groovy/unstable.

Thanks,
Seth

> 
> Seth Forshee <seth.forshee at canonical.com> 於 2020年7月29日 週三 下午9:10寫道:
> >
> > On Mon, May 04, 2020 at 12:14:40PM +0800, AceLan Kao wrote:
> > > I'll check this driver on all series later and make sure the code
> > > corresponds with all series.
> > > Thanks for the reminder.
> >
> > It looks like the 5.8 groovy kernel still uses get_scalar_status, can we
> > please get a patch for this?
> >
> > >
> > > Seth Forshee <seth.forshee at canonical.com> 於 2020年5月1日 週五 上午4:40寫道:
> > > >
> > > > On Fri, Mar 20, 2020 at 05:38:36PM -0500, Seth Forshee wrote:
> > > > > On Wed, Mar 11, 2020 at 10:00:04PM +0800, AceLan Kao wrote:
> > > > > > BugLink: https://bugs.launchpad.net/bugs/1865402
> > > > > >
> > > > > > [Impact]
> > > > > > The get_scalar_status command was provided by ODM engineer and was newly
> > > > > > introduced to determinate whether scalar is responsible for the backlight
> > > > > > adjustment. That guy asked the scalar vendor to add this command and the
> > > > > > command works as expected. But there is already a command in the Dell AIO
> > > > > > scalar UART command spec. which can do the same thing since 2015, and the
> > > > > > newly introduced get_scalar_status command is undocumented. To prevent
> > > > > > from introducing regression in the future and to align with what Windows
> > > > > > uses, replace this command with get_display_mode command.
> > > > > >
> > > > > > [Fix]
> > > > > > Replace get_scalar_status command with get_display_mode command.
> > > > > >
> > > > > > [Test]
> > > > > > Verified on new Dell AIO platforms.
> > > > > >
> > > > > > [Regression Potential]
> > > > > > Low, the command is already in the spec. since 2015.
> > > > >
> > > > > The patches for focal and unstable do not apply. This looks like it has
> > > > > to do with the revert of "UBUNTU: SAUCE: platform/x86:
> > > > > dell-uart-backlight: move retry block" and that your patch may need to
> > > > > be updated in light of that revert.
> > > >
> > > > Ping, I don't think we've ever seen an updated patch for F/Unstable.



More information about the kernel-team mailing list