ACK/Cmnt: [SRU][FOCAL][PATCH 1/1] kvm: svm: Update svm_xsaves_supported

[William Breathitt Gray]

On Wed, Sep 16, 2020 at 05:26:34PM +0200, Stefan Bader wrote:
> On 15.09.20 22:53, William Breathitt Gray wrote:
> > From: Aaron Lewis <aaronlewis at google.com>
> > 
> > AMD CPUs now support XSAVES in a limited fashion (they require IA32_XSS
> > to be zero).
> > 
> > AMD has no equivalent of Intel's "Enable XSAVES/XRSTORS" VM-execution
> > control. Instead, XSAVES is always available to the guest when supported
> > on the host.
> > 
> > Reviewed-by: Jim Mattson <jmattson at google.com>
> > Signed-off-by: Aaron Lewis <aaronlewis at google.com>
> > Change-Id: I40dc2c682eb0d38c2208d95d5eb7bbb6c47f6317
> > Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
> > BugLink: https://bugs.launchpad.net/bugs/1887490
> > (cherry-picked from commit 52297436199dde85be557ee6bc779f5b96082f74)
> > Signed-off-by: William Breathitt Gray <william.gray at canonical.com>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
> > ---
> 
> I would not insist on the location of the BugLink line but "cherry picked"
> should be used and when adding that we can as well move the BugLink. Personally
> I would leave one empty line between the old sob block and the new one but that
> is opinion as well.
> 
> -Stefan

I think it makes sense to keep the BugLink line together with the new
sob block (an empty line seperation is also a good idea); this should
make it obvious that the new block of information is not part of the
original upstream patch. I don't feel too strongly about it though, so I
can go either way.

William Breathitt Gray

> 
> >  arch/x86/kvm/svm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> > index 3243a80ea32c..027004daec56 100644
> > --- a/arch/x86/kvm/svm.c
> > +++ b/arch/x86/kvm/svm.c
> > @@ -6019,7 +6019,7 @@ static bool svm_mpx_supported(void)
> >  
> >  static bool svm_xsaves_supported(void)
> >  {
> > -	return false;
> > +	return boot_cpu_has(X86_FEATURE_XSAVES);
> >  }
> >  
> >  static bool svm_umip_emulated(void)
> > 
> 
> 




> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200916/9f1aa5ee/attachment.sig>