ACK/Cmnt: [PATCH v2] UBUNTU: SAUCE: PCI: Enable ACS quirk on all CML root ports

[Stefan Bader]

On 22.10.20 07:51, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1895718

BugLink: https://bugs.launchpad.net/bugs/1900847

> 
> In addition to KIOXIA NVMe, Intel NVMe under another root port also has
> the same ACS violation issue.
> 
> According to Intel, all CML root ports need this workaround, so add all
> root ports from [1] to existing quirk.
> 
> [1] Intel® 400 Series Chipset Family Platform Controller Hub (PCH) Datasheet, Volume 1 of 2, Content ID: 620854	Version: 002
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
Acked-by: Stefan Bader <stefan.bader at canonical.com>
> ---

Maybe you should use titles in bug reports which differ in more than just a
word. ;) The BugLink in the patch needs to be adjusted before applying.

-Stefan

>  drivers/pci/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index cfa7387a12b9..706f27a86a8e 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4665,7 +4665,7 @@ static bool pci_quirk_intel_spt_pch_acs_match(struct pci_dev *dev)
>  		return false;
>  
>  	switch (dev->device) {
> -	case 0x06ac: /* Comet Lake */
> +	case 0x06ac ... 0x06c3: /* Comet Lake */
>  	case 0xa110 ... 0xa11f: case 0xa167 ... 0xa16a: /* Sunrise Point */
>  	case 0xa290 ... 0xa29f: case 0xa2e7 ... 0xa2ee: /* Union Point */
>  	case 0x9d10 ... 0x9d1b: /* 7th & 8th Gen Mobile */
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20201022/391aadfb/attachment.sig>