APPLIED [OEM-5.6] Re: [F][G][OEM-5.6][Unstable][SRU][PATCH 0/1] Improve descriptions for XFAIL cases in kselftests/net/psock_snd

Timo Aaltonen tjaalton at ubuntu.com
Fri Oct 16 09:37:26 UTC 2020


On 16.10.2020 10.15, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1900088
> 
> == SRU Justification ==
> The test output in psock_snd.sh is confusing sometimes.
> Here is an output example:
>    raw csum_off with bad offset (fails)
>    ./psock_snd: write: Invalid argument
> 
> The first line is the test case description, and the second is the
> test execution output.
> 
> It feels like this test has failed, but it has passed instead.
> The "fails" here means this test is expected to fail. But you will
> have to check the source code to know this fact.
> 
> == Fix ==
> * 30ae801746ea selftests/net: improve descriptions for XFAIL cases in
> psock_snd.sh
> 
> Change "fails" in the test case description to "expected to fail", so
> that the test output can be more understandable.
> 
> This test case exists after Bionic, and it can be cherry-picked.
> 
> == Test ==
> Patch tested by applying to the tree directly, the test description
> will be changed as expected.
> 
> == Regression Potential ==
> Low, minor changes for test case description only.
> 
> Po-Hsu Lin (1):
>    selftests/net: improve descriptions for XFAIL cases in psock_snd.sh
> 
>   tools/testing/selftests/net/psock_snd.sh | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 

applied to oem-5.6, thanks

-- 
t



More information about the kernel-team mailing list