NACK/Cmnt: [SRU][X][B][F][PATCH 0/1] Change NET_IPIP and IPV6_SIT to modules

Stefan Bader stefan.bader at canonical.com
Thu Oct 15 07:43:24 UTC 2020


On 15.10.20 04:18, Khalid Elmously wrote:
> BugLink: https://bugs.launchpad.net/bugs/1899832
> 
> There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.
> 
> 
> Khalid Elmously (1):
>   Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m
> 
>  debian.kvm/config/config.common.ubuntu | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

The subject line is confusingly written as if the patches were for the primary
kernels. And there is a Groovy/linux-kvm which should be checked and fixed as
well. So subject should be "[SRU G,F,B,X/linux-kvm] ...". Also the bug report
does not contain a complete SRU justification template and the regression
potential should rather be something like "Early boot code might have been
depending on the net devices being present, however that can be mitigated by
probing for those". And speaking of that, did we check that the packaging of kvm
kernels automatically picks those modules up and into linux-modules?
[also the bug report could be nominated for all the series this should be
considered for]

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20201015/bbf622c1/attachment.sig>


More information about the kernel-team mailing list