[SRU][F][PATCH 0/1] ceph: fix inode number handling on arches with 32-bit ino_t (LP: 1899582)

frank.heimes at canonical.com frank.heimes at canonical.com
Wed Oct 14 19:12:00 UTC 2020


BugLink: https://bugs.launchpad.net/bugs/1899582

SRU Justification:

[Impact]

* A problem occurs with 32-bit ino_t values on 64-bit architectures (like s390x).

* Without this patch, cephfs kernel client does not work properly on s390x: the initial symtom is missing the first created file/directory on cephfs mount point as reported in https://tracker.ceph.com/issues/46828.

[Fix]

* cherry-pick for groovy: ebce3eb2f7ef9f6ef01a60874ebd232450107c9a ebce3eb2f7ef "ceph: fix inode number handling on arches with 32-bit ino_t"

* backport for focal: https://launchpadlibrarian.net/501822049/0001-ceph-fix-inode-number-handling-on-arches-with-32-bit.patch

[Test Case]

* IBM Development team and Test team have carried out simple testing and stress testing by automatically creating many Ceph clusters on s390x (with different configuration each time), doing the cephfs kernel mounting, checking inode numbers, running stress tests. The same procedures were done on x86_64 arch by Test team.

[Regression Potential]

* There is a certain regression risk with this patch, since:

* common ceph filesystem code in fs/ceph/ is modified

* the inode handling is touched

* ceph is used for supplemental volumes

* and as the original author of this patch (Jeff Layton) wrote in the commit message, the potential issue might happen on 32-bit arches only and he also provided workaround for those arches.

[Other]

* The above patch/commit was upstream accepted with kernel 5.9.

* Cherry picking the patch/commit to groovy works fine, hence this SRU.

* For focal a cherry pick does not apply cleanly, hence a backport got added to LP 1899582.

Tuan Hoang (1):
  ceph: fix inode number handling on arches with 32-bit ino_t

 fs/ceph/caps.c    | 12 ++++----
 fs/ceph/debugfs.c |  2 +-
 fs/ceph/dir.c     | 29 ++++++++-----------
 fs/ceph/inode.c   | 21 +++++++-------
 fs/ceph/quota.c   |  4 +--
 fs/ceph/super.h   | 73 ++++++++++++++++++++++++-----------------------
 6 files changed, 69 insertions(+), 72 deletions(-)

-- 
2.25.1




More information about the kernel-team mailing list