ACK/Cmnt: [F/G/Unstable/OEM-5.6] [PATCH 3/3] UBUNTU: SAUCE: ALSA: hda: fix jack detection with Realtek codecs when in D3
andrea.righi at canonical.com
Tue Oct 13 13:19:38 UTC 2020
On Tue, Oct 13, 2020 at 03:53:55PM +0800, Kai-Heng Feng wrote:
> From: Kai Vehmanen <kai.vehmanen at linux.intel.com>
> BugLink: https://bugs.launchpad.net/bugs/1899586
> In case HDA controller becomes active, but codec is runtime suspended,
> jack detection is not successful and no interrupt is raised. This has
> been observed with multiple Realtek codecs and HDA controllers from
> different vendors. Bug does not occur if both codec and controller are
> active, or both are in suspend. Bug can be easily hit on desktop systems
> with no built-in speaker.
> The problem can be fixed by powering up the codec once after every
> controller runtime resume. Even if codec goes back to suspend later, the
> jack detection will continue to work. Add a flag to 'hda_codec' to
> describe codecs that require this flow from the controller driver.
> Modify __azx_runtime_resume() to use pm_request_resume() to make the
> intent clearer.
> Mark all Realtek codecs with the new forced_resume flag.
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=209379
> Cc: Kailang Yang <kailang at realtek.com>
> Co-developed-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> Signed-off-by: Kai Vehmanen <kai.vehmanen at linux.intel.com>
> Cc: <stable at vger.kernel.org>
> Link: https://email@example.com
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> (cherry picked from commit a6e7d0a4bdb02a7a3ffe0b44aaa8842b7efdd056 git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git master)
It looks like this one landed also in -next, so we can probably replace
the git URI with "linux-next" when this patch is applied.
Apart than that, looks good to me:
Acked-by: Andrea Righi <andrea.righi at canonical.com>
More information about the kernel-team