ACK/cmnt: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Kleber Souza kleber.souza at canonical.com
Thu Oct 8 11:21:14 UTC 2020


On 07.10.20 13:53, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1898865
> 
> [Impact]
> Brightness on HP DreamColor panel, which can be found on new HP Zbook
> Studio, cannot be changed.
> 
> [Fix]
> Let DRM know the panel should use DPCD instead of PWM to control
> backlight.
> 
> [Test]
> With the patch applied, we can change the brightness on HP Zbook Studio.
> 
> [Regression Potential]
> If there's any panel in the quirk list depends on checking brightness
> control capability then this change will have an impact. However it's
> rather unlikely because it defeats the purpose of the quirk list.
> 
> Kai-Heng Feng (2):
>   UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with
>     force DPCD quirk
>   UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix
> 
> Lyude Paul (1):
>   drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
> 
>  drivers/gpu/drm/drm_dp_helper.c                       | 1 +
>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++++++---
>  2 files changed, 7 insertions(+), 3 deletions(-)
> 

With the (cherry picked from ...) line added as pointed out by
Stefan:

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>



More information about the kernel-team mailing list