[PATCH 2/3] net: hns3: minor refactor for hns3_rx_checksum
Ike Panhc
ike.pan at canonical.com
Thu Oct 8 05:32:45 UTC 2020
From: Yunsheng Lin <linyunsheng at huawei.com>
BugLink: https://launchpad.net/bugs/1893711
Change the parameters of hns3_rx_checksum to be more specific to
what is used internally, rather than passing in a pointer to the
whole hns3_desc. Reduces duplicate code and bring this function
inline with the approach used in hns3_set_gro_param.
Signed-off-by: Yunsheng Lin <linyunsheng at huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong at huawei.com>
Signed-off-by: David S. Miller <davem at davemloft.net>
(cherry picked from commit a4d2cdcbb878d4d5828cd4124104c330d2817211)
Signed-off-by: Ike Panhc <ike.pan at canonical.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index ee3ac4f946ef..4fda2c39889f 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -2312,16 +2312,11 @@ static void hns3_nic_reuse_page(struct sk_buff *skb, int i,
}
static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
- struct hns3_desc *desc)
+ u32 l234info, u32 bd_base_info)
{
struct net_device *netdev = ring->tqp->handle->kinfo.netdev;
int l3_type, l4_type;
- u32 bd_base_info;
int ol4_type;
- u32 l234info;
-
- bd_base_info = le32_to_cpu(desc->rx.bd_base_info);
- l234info = le32_to_cpu(desc->rx.l234_info);
skb->ip_summed = CHECKSUM_NONE;
@@ -2714,7 +2709,7 @@ static int hns3_handle_rx_bd(struct hns3_enet_ring *ring,
/* This is needed in order to enable forwarding support */
hns3_set_gro_param(skb, l234info, bd_base_info);
- hns3_rx_checksum(ring, skb, desc);
+ hns3_rx_checksum(ring, skb, l234info, bd_base_info);
*out_skb = skb;
hns3_set_rx_skb_rss_type(ring, skb);
--
2.25.1
More information about the kernel-team
mailing list