ACK / APPLIED[G/Unstable]: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/1] Fix broken e1000e device after S3
Seth Forshee
seth.forshee at canonical.com
Fri Oct 2 01:02:47 UTC 2020
On Tue, Sep 29, 2020 at 11:07:03PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1897755
>
> [Impact]
> Intel I219 ethernet on several HP workstations has a chance to stop
> working after S3.
>
> [Fix]
> Increase polling timeout on MDIC ready bit so we wait a bit longer for
> Intel ME.
>
> [Test]
> Without the fix, the I219 ethernet breaks in 10 S3 cycle.
> With the fix applied, the ethernet keeps working after 1000+ S3 stress
> test.
>
> [Regression Potential]
> If the firmware/hardware is _really_ broken, we'll waste a bit more time
> to wait the device resume. Otherwise no functional change.
An increased timeout seems preferable to broken networking.
Acked-by: Seth Forshee <seth.forshee at canonical.com>
Applied to groovy/master-next and unstable/master, thanks!
More information about the kernel-team
mailing list