ACK/CMT[G]: [PATCH 0/5][SRU][G][OEM-5.6] Tiger Lake PMC core driver fixes

Kelsey Skunberg kelsey.skunberg at canonical.com
Thu Nov 5 23:33:51 UTC 2020


Reviewed the Groovy patches and all are clean cherry picks. LGTM. I
added the additional impact information you sent to the bug description. 

Thanks! 

-Kelsey

Acked-by: Kelsey Skunberg <kelsey.skunberg at canonical.com>

On 2020-10-30 14:01:46 , AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1899883
> 
> [Impact]
> The power gating status is not correct and the slp_s0 value is not correct
> on Intel TigerLake platform.
> 
> [Fix]
> The patchset in
> https://lore.kernel.org/lkml/20201006224702.12697-1-david.e.box@linux.intel.com/
> provides several critical fixes for intel_pmc_core driver.
> 
> [Test]
> Verified on some TigerLake platforms
> 
> [Regression Potential]
> Low, the fix for status bits map and the slp_s0 calculation are simple
> and clear, should have low impact on regression.
> 
> David E. Box (1):
>   platform/x86: pmc_core: Use descriptive names for LPM registers
> 
> Gaurav Singh (1):
>   platform/x86: intel_pmc_core: fix bound check in
>     pmc_core_mphy_pg_show()
> 
> Gayatri Kammela (2):
>   platform/x86: intel_pmc_core: Fix TigerLake power gating status map
>   platform/x86: intel_pmc_core: Fix the slp_s0 counter displayed value
> 
> Sathyanarayana Nujella (1):
>   platform/x86: intel_pmc_core: update TGL's LPM0 reg bit map name
> 
>  drivers/platform/x86/intel_pmc_core.c | 86 ++++++++++++++-------------
>  drivers/platform/x86/intel_pmc_core.h |  5 +-
>  2 files changed, 49 insertions(+), 42 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list