NACK/Cmnt: [PATCH 0/1][SRU][F/OEM-5.6]drm/i915/dp_mst - System would hang during the boot up

[Stefan Bader]

On 03.11.20 03:55, Koba Ko wrote:
> On Mon, Nov 2, 2020 at 7:28 PM Stefan Bader <stefan.bader at canonical.com
> <mailto:stefan.bader at canonical.com>> wrote:
> 
>     On 02.11.20 06:46, Koba Ko wrote:
>     > BugLink: https://bugs.launchpad.net/bugs/1902469
>     >
>     > [Impact]
>     > The machine connect with the external monitor on dock(Thunderbolt),
>     > Then system would hang during the boot-up.
>     >
>     > [Fix]
>     > The atomic check hooks must look up the encoder to be used with a
>     > connector from the connector's atomic state, and not assume that it's
>     > the connector's current attached encoder. The latter one can change
>     > under the atomic check func, or can be unset yet as in the case of MST
>     > connectors.
>     >
>     > [test]
>     > With the patch, The machine connect with the external monitor on
>     dock(Thunderbolt),
>     > Then system boot up successfully.
>     >
>     > [Regression Potential]
>     > Low. This patch is also verified by others and is archived in the drmtip.
>     >
>     > Imre Deak (1):
>     >   drm/i915: Fix encoder lookup during PSR atomic check
>     >
>     >  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
>     >  1 file changed, 1 insertion(+), 1 deletion(-)
>     >
>     Is this focal/oem-5.6 only? The bug report points at focal/linux.
> 
>     -Stefan
> 
> I thought "[F/OEM5.6]" is for Focal-generic and OEM5.6.
> If I want to SRU to focal/linux, would you please guide me how to state!?

It is confusing because mostly the form <series>/<kernel> is used to target a
certain kernel in the given series. So in case you want to target both it is
better to say either "focal + focal/[linux-]oem-5.6" or "focal/linux +
[linux-]oem-5.6". And the bug report would affect linux and also linux-oem-5.6.
Both nominated for focal.
Note that, based on the reply of Alex, this seems to be required at least in
groovy/linux, too. And as of now, you probably should check Hirsute/5.10 as well.

With all this, it would be best if you re-submitted that patch with an updated
target(s).

Thanks,
Stefan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20201103/7aa6b388/attachment.sig>