ACK/cmnt: [PATCH 00/10][SRU][F/OEM-5.6] Fix Realtek 8723DE disconnects unsolicitedly when Bluetooth is paired: Reason: 23=IEEE8021X_FAILED

[Kleber Souza]

On 2020-05-29 08:17, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1878147
> 
> [Impact]
> Existing Wi-Fi connection may be deauthenticated unsolicitedly with
> reason 23=IEEE8021X_FAILED when the system is also paired with a
> Bluetooth device. A WLAN passphrase dialog propmpts, and system
> disconnects from network:
> 
>   wlp5s0: deauthenticated from a4:56:30:cc:0f:30 (Reason: 23=IEEE8021X_FAILED).
> 
> [Fix]
> Realtek proposed a fix[1] to linux-wireless consisting of three patches.
> 
>   rtw88: coex: 8723d: set antanna control owner
>   rtw88: coex: 8723d: handle BT inquiry cases
>   rtw88: fix EAPOL 4-way failure by finish IQK earlier
> 
> The third one actually duplicates the fix we have for bug 1871300 also
> from Realtek and was claimed critical to this issue, therefore those for
> bug 1871300 are reverted in favor of the new one.
> 
> Also revert that Ubuntu sauced "rtw88: 8723d: Add coex support" commit
> and replace it with the upstream one, and cherry picked two more debugfs
> changes due to dependency to bt coex functionality.
> 
> [1]: https://lore.kernel.org/linux-wireless/20200518081444.7664-1-yhchuang@realtek.com/
> 
> [Test Case]
> 1. Associate to a WLAN,
> 2. Pair with some Bluetooth device, e.g. headset,
> 3. Run a stress test script to disconnect and reconnect Wi-Fi for 200
>    runs,
> 4. Make sure Wi-Fi passphrase dialog doesn't prompt at the end of the
>    test.
> 
> [Regression Potential]
> Low. These changes are mostly about rtl8723de or 11n, which is also for
> 8723de.
> 
> Ping-Ke Shih (4):
>   rtw88: 8723d: Add coex support
>   rtw88: coex: 8723d: set antanna control owner
>   rtw88: coex: 8723d: handle BT inquiry cases
>   rtw88: fix EAPOL 4-way failure by finish IQK earlier
> 
> Yan-Hsuan Chuang (2):
>   rtw88: add a debugfs entry to dump coex's info
>   rtw88: add a debugfs entry to enable/disable coex mechanism
> 
> You-Sheng Yang (4):
>   Revert "UBUNTU: SAUCE: rtw88: Move driver IQK to set channel before
>     association for 11N chip"
>   Revert "UBUNTU: SAUCE: rtw88: fix rate for a while after being
>     connected"
>   Revert "UBUNTU: SAUCE: rtw88: No retry and report for auth and assoc"
>   Revert "UBUNTU: SAUCE: rtw88: 8723d: Add coex support"
> 
>  drivers/net/wireless/realtek/rtw88/coex.c     | 513 +++++++++++++++++-
>  drivers/net/wireless/realtek/rtw88/coex.h     |  10 +
>  drivers/net/wireless/realtek/rtw88/debug.c    |  62 +++
>  drivers/net/wireless/realtek/rtw88/mac80211.c |   8 +-
>  drivers/net/wireless/realtek/rtw88/main.c     |  18 +-
>  drivers/net/wireless/realtek/rtw88/main.h     |  22 +-
>  drivers/net/wireless/realtek/rtw88/rtw8723d.c |  35 +-
>  drivers/net/wireless/realtek/rtw88/rtw8723d.h |   1 +
>  drivers/net/wireless/realtek/rtw88/rtw8822b.c |  30 +
>  drivers/net/wireless/realtek/rtw88/rtw8822c.c |  28 +
>  drivers/net/wireless/realtek/rtw88/tx.c       |  20 -
>  drivers/net/wireless/realtek/rtw88/tx.h       |   5 -
>  12 files changed, 705 insertions(+), 47 deletions(-)
> 

Vicamo, could you please add the SRU template to the bug report?

Otherwise the changes look good to me.

Acked-by: Kleber Sacilotto de Souza <kleber.souza at canonical.com>