[PATCH 1/2][SRU][OEM-5.6] PCI/PM: Adjust pcie_wait_for_link_delay() for caller delay
Koba Ko
koba.ko at canonical.com
Thu May 28 16:47:12 UTC 2020
From: Bjorn Helgaas <bhelgaas at google.com>
BugLink: https://bugs.launchpad.net/bugs/1876844
The caller of pcie_wait_for_link_delay() specifies the time to wait after
the link becomes active. When the downstream port doesn't support link
active reporting, obviously we can't tell when the link becomes active, so
we waited the worst-case time (1000 ms) plus 100 ms, ignoring the delay
from the caller.
Instead, wait for 1000 ms + the delay from the caller.
Fixes: 4827d63891b6 ("PCI/PM: Add pcie_wait_for_link_delay()")
Signed-off-by: Bjorn Helgaas <bhelgaas at google.com>
(cherry picked from commit f044baaff1eb7ae5aa7a36f1b7ad5bd8eeb672c4
linux-next)
Signed-off-by: Koba Ko <koba.ko at canonical.com>
---
drivers/pci/pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 57acc8a26336..2f41163d65f8 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4602,10 +4602,10 @@ static bool pcie_wait_for_link_delay(struct pci_dev *pdev, bool active,
/*
* Some controllers might not implement link active reporting. In this
- * case, we wait for 1000 + 100 ms.
+ * case, we wait for 1000 ms + any delay requested by the caller.
*/
if (!pdev->link_active_reporting) {
- msleep(1100);
+ msleep(timeout + delay);
return true;
}
--
2.17.1
More information about the kernel-team
mailing list