ACK: [SRU][Xenial][PATCH 0/1] Fix for ext2 build failure

[Ian May]

I agree, I should've explained the situation better.  Sorry for the
confusion!

Thanks,
Ian

On 5/25/20 6:26 AM, Thadeu Lima de Souza Cascardo wrote:
> On Sun, May 24, 2020 at 10:05:15PM -0500, Ian May wrote:
>> Currently, xenial/linux-snapdragon has CONFIG_EXT2_FS enabled and is
>> failing to build due to this build error in Ext2.  I was advised to also
>> submit the upstream patch for the Xenial SRU.
>>
>> Thanks,
>> Ian
> Okay, it would be nice to explain that in the bug Impact, I'd say. Thanks for
> the explanation.
>
> Acked-by: Thadeu Lima de Souza Cascardo <cascardo at canonical.com>
>
>> On Fri, May 22, 2020 at 5:12 PM Thadeu Lima de Souza Cascardo <
>> cascardo at canonical.com> wrote:
>>
>>> On Fri, May 22, 2020 at 04:15:51PM -0500, Ian May wrote:
>>>> BugLink: https://bugs.launchpad.net/bugs/1880213
>>>>
>>>> [Impact]
>>>> Build failure when building ext2
>>>>
>>>> fs/ext2/xattr.c:828:18: error: 'ext2_xattr_cache' undeclared (first use
>>> in this function)
>>>>      atomic_read(&ext2_xattr_cache->c_entry_count));
>>>>
>>>> [Fix]
>>>> The fix is upstream commit 32302085a8d90859c40cf1a5e8313f575d06ec75
>>> "ext2: fix debug reference to ext2_xattr_cache"
>>>> [Test case]
>>>> Enable CONFIG_EXT2_FS and build kernel
>>>>
>>> What is the motivation behind this?
>>>
>>> Cascardo.
>>>
>>>> [Regression potential]
>>>> Low, fix is changing the contents of a print to a string literal.
>>>>
>>>> Jan Kara (1):
>>>>   ext2: fix debug reference to ext2_xattr_cache
>>>>
>>>>  fs/ext2/xattr.c | 3 +--
>>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> --
>>>> 2.25.1
>>>>
>>>>
>>>> --
>>>> kernel-team mailing list
>>>> kernel-team at lists.ubuntu.com
>>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team