NAK/CMNT: [PATCH 1/1] [SRU][OEM-OSP1-B] UBUNTU: SAUCE: platform/x86: dell-laptop: don't register platform::micmute if the related tokens don't exist.

[Sultan Alsawaf]

On Thu, May 14, 2020 at 08:21:27AM +0800, Koba Ko wrote:
> On Thu, May 14, 2020 at 1:48 AM Sultan Alsawaf <sultan.alsawaf at canonical.com>
> wrote:
> 
> > Hi,
> >
> > This change breaks the error path in this function because it can perform
> > an
> > unregister on the led classdev when it is not registered. It looks like you
> > realized this is a problem with your LKML submission, so you should update
> > this
> > sauce patch accordingly. Also, you should implement the other comments
> > that the
> > reviewers on LKML left for you [1].
> >
> > Thanks,
> > Sultan
> >
> > [1] https://patchwork.kernel.org/patch/11533437
> 
> Hi Sultan,
> As per the message[A], it's not a strong requirement.
> How do you think!?
> [A]https://www.spinics.net/lists/platform-driver-x86/msg21661.html

That looks correct to me, but that commit is only in Linux 5.4+. The bionic
linux-oem-osp1 kernel is based on 5.0, so it needs to have a check before
calling led_classdev_unregister().

I'll ack the oem-5.6 version you submitted once the commit message in that one
is cleaned up. You only need to remove these two lines from that commit message:
> (cherry picked from commit f0a165c6311a4b8c7b45bafcb4806f105f0e7aa1)
> Signed-off-by: Koba Ko <koba.ko at canonical.com>

You need to remove the "cherry picked from" because that isn't an upstream
cherry pick, and you need to remove your duplicate Signed-off-by. Then it'll
look good to me.

Sultan