ACK/Cmnt: [SRU][F][PATCH 0/2] Upstream fix for i915_active_acquire crash

[Stefan Bader]

On 13.05.20 20:10, Sultan Alsawaf wrote:
> BugLink: https://bugs.launchpad.net/bugs/1868551
> 
> SRU Justification:
> 
> [Impact]
> Users are experiencing a frequent NULL pointer dereference crash in
> i915_active_acquire when using kms, which is used by default.
> 
> [Fix]
> The fix is a cherry pick from upstream which was supposed to be backported to
> 5.4 by upstream, but was neglected. The fix has a subsequent Fixes patch to
> resolve some uninitialized pointer usage.
> 
> [Test]
> Verified by multiple bug reporters.
> 
> [Regression Potential]
> Low. Although there are a lot of lines added, they're mostly boilerplate, and
> this patch is confirmed by multiple users to fix a crash.
> 

Lets meet at medium. No change to i915 seems to come without some risk.
Please add the justification to the bug report, too. And update the status of
the devel task (for groovy).

> Chris Wilson (1):
>   drm/i915: Hold reference to intel_frontbuffer as we track activity
> 
> Colin Ian King (1):
>   drm/i915: fix uninitialized pointer reads on pointers to and from
> 
>  drivers/gpu/drm/i915/display/intel_display.c  |  2 +-
>  .../gpu/drm/i915/display/intel_frontbuffer.c  | 16 ++++-----
>  .../gpu/drm/i915/display/intel_frontbuffer.h  | 34 +++++++++++++++++--
>  drivers/gpu/drm/i915/display/intel_overlay.c  | 17 +++++++---
>  drivers/gpu/drm/i915/gem/i915_gem_clflush.c   |  3 +-
>  drivers/gpu/drm/i915/gem/i915_gem_domain.c    |  4 +--
>  drivers/gpu/drm/i915/gem/i915_gem_object.c    | 26 +++++++++++++-
>  drivers/gpu/drm/i915/gem/i915_gem_object.h    | 23 ++++++++++++-
>  .../gpu/drm/i915/gem/i915_gem_object_types.h  |  2 +-
>  drivers/gpu/drm/i915/i915_gem.c               | 10 +++---
>  drivers/gpu/drm/i915/i915_vma.c               | 14 +++++---
>  11 files changed, 118 insertions(+), 33 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader at canonical.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200514/3c9ba09f/attachment.sig>