[SRU][F][PATCH 0/2] Upstream fix for i915_active_acquire crash

Sultan Alsawaf sultan.alsawaf at canonical.com
Wed May 13 18:10:47 UTC 2020


BugLink: https://bugs.launchpad.net/bugs/1868551

SRU Justification:

[Impact]
Users are experiencing a frequent NULL pointer dereference crash in
i915_active_acquire when using kms, which is used by default.

[Fix]
The fix is a cherry pick from upstream which was supposed to be backported to
5.4 by upstream, but was neglected. The fix has a subsequent Fixes patch to
resolve some uninitialized pointer usage.

[Test]
Verified by multiple bug reporters.

[Regression Potential]
Low. Although there are a lot of lines added, they're mostly boilerplate, and
this patch is confirmed by multiple users to fix a crash.

Chris Wilson (1):
  drm/i915: Hold reference to intel_frontbuffer as we track activity

Colin Ian King (1):
  drm/i915: fix uninitialized pointer reads on pointers to and from

 drivers/gpu/drm/i915/display/intel_display.c  |  2 +-
 .../gpu/drm/i915/display/intel_frontbuffer.c  | 16 ++++-----
 .../gpu/drm/i915/display/intel_frontbuffer.h  | 34 +++++++++++++++++--
 drivers/gpu/drm/i915/display/intel_overlay.c  | 17 +++++++---
 drivers/gpu/drm/i915/gem/i915_gem_clflush.c   |  3 +-
 drivers/gpu/drm/i915/gem/i915_gem_domain.c    |  4 +--
 drivers/gpu/drm/i915/gem/i915_gem_object.c    | 26 +++++++++++++-
 drivers/gpu/drm/i915/gem/i915_gem_object.h    | 23 ++++++++++++-
 .../gpu/drm/i915/gem/i915_gem_object_types.h  |  2 +-
 drivers/gpu/drm/i915/i915_gem.c               | 10 +++---
 drivers/gpu/drm/i915/i915_vma.c               | 14 +++++---
 11 files changed, 118 insertions(+), 33 deletions(-)

-- 
2.20.1




More information about the kernel-team mailing list