ACK/Cmnt: [SRU] [F] [PATCH 0/5] Support DMIC micmute LED on HP platforms

[Stefan Bader]

On 13.05.20 14:06, Kai-Heng Feng wrote:
> 
> 
>> On May 13, 2020, at 19:52, Stefan Bader <stefan.bader at canonical.com> wrote:
>>
>> On 05.05.20 08:02, Kai-Heng Feng wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1876859
>>>
>>> [Impact]
>>> DMIC micmute LED on HP platforms doesn't work.
>>>
>>> [Fix]
>>> Add LED class support from HDA codec, so DMIC can use LEDS_TRIGGER_AUDIO
>>> to control micmute.
>>>
>>> [Test]
>>> After applying the fix, micmute LED can correctly indicate the status of
>>> micmute.
>>>
>>> [Regression Potential]
>>> Low. For now it only affects one platform, and it doesn't touch any core
>>> part of the subsystem.
>>>
>>> Kai-Heng Feng (4):
>>>  ALSA: hda/realtek - Introduce polarity for micmute LED GPIO
>>>  ALSA: hda/realtek - Enable micmute LED on and HP system
>>>  ALSA: hda/realtek - Add LED class support for micmute LED
>>>  ASoC: SOF: Update correct LED status at the first time usage of
>>>    update_mute_led()
>>
>> It is not that obvious how the ASoC patch relates to the rest. Everything else
>> is somehow mentioning HP systems and hda/realtek. And the fixes line in the ASoC
>> patch also refers to some other patch.
> 
> The entire series in hda/realtek is to expose an interface that can be used by ASoC/SoF DMIC driver.
> 
>>
>> So why is this part of this SRU submission?
> 
> The 5th patch is to make Mic mute LED show correct status at boot.
> Without that fix, the mic mute led doesn't reflect actual mic mute status, until we mute/unmute microphone two times.
> Hence the 5th patch is needed to fully enable mic mute LED support.
> 
> Kai-Heng
> 
>>
>>>
>>> Takashi Iwai (1):
>>>  ALSA: hda/realtek - Fix unused variable warning w/o
>>>    CONFIG_LEDS_TRIGGER_AUDIO
>>>
>>> sound/pci/hda/patch_realtek.c | 51 ++++++++++++++++++++++++++++++-----
>>> sound/soc/sof/control.c       |  4 +--
>>> sound/soc/sof/sof-priv.h      |  2 +-
>>> sound/soc/sof/topology.c      |  2 ++
>>> 4 files changed, 49 insertions(+), 10 deletions(-)
>>>
>>
>> Provided we get some justification for the 5th patch, the ack is for all 5,
>> otherwise we should be applying only the first 4.
> 
> Hopefully the explanation above is good enough...

Ok, fair enough. So 4 pre-reqs and the actual patch for ASoC. Just hard to tell
without explanation that that is a HP system, too.

> 
> Kai-Heng
> 
>>
>> Acked-by: Stefan Bader <stefan.bader at canonical.com>
>>
>> -- 
>> kernel-team mailing list
>> kernel-team at lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20200513/6cebccdc/attachment.sig>