[PATCH 0/1][SRU][Bionic] add 16-bit width registers support for EEPROM at24 device

AceLan Kao acelan.kao at canonical.com
Wed May 13 03:58:20 UTC 2020


Yes, the 2 patches applied to 2 different files.
The patch I got from the customer is more like a diff, so there is no
s-o-b of the author.
I tried to preserve the author info, but I think I can't add the
author s-o-b by myself.
That's why there is no author s-o-b on the patch.

The read/write functions in file at24.c change a lot after v4.15, so I
mimic the read/write function in at24.c
and migrate the code to the latest mainline kernel. That leads to the
2 patches looking so different.

Kleber Souza <kleber.souza at canonical.com> 於 2020年5月13日 週三 上午12:34寫道:
>
> On 04.05.20 13:19, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1876699
> >
> > [Impact]
> > Larger EEPROM devices that use 16-bit addresses couldn't be accessed.
> >
> > [Fix]
> > The commit is from
> > https://patchwork.ozlabs.org/patch/545292/
> >
> > Unfortunately, this commit doesn't get into mainline in the end, so I
> > migrate the commit to latest kernel and finally get it merged.
> > https://lkml.org/lkml/2020/4/24/635
>
> Hi AceLan,
>
> These two patches mentioned above seem to be completely different. The commit
> message is similar, but they add different code to different files.
>
> Also, the patch has a "From: ..." tag but there is no s-o-b of the author of
> the patch.
>
> Can you please clarify?
>
>
> Thanks,
> Kleber
>
>
> >
> > [Test]
> > Verified on Eurotech's platforms.
> >
> > [Regression Potential]
> > Low, this patch only changes the behavior of the device which has
> > AT24_FLAG_ADDR16 flag and change the page_size to 64 if the device name is 24c256.
> >
> > Pieri (1):
> >   UBUNTU: SAUCE: at24: add 16-bit width registers support
> >
> >  drivers/misc/eeprom/Kconfig |   5 +-
> >  drivers/misc/eeprom/at24.c  | 139 +++++++++++++++++++++++++++++++-----
> >  2 files changed, 127 insertions(+), 17 deletions(-)
> >
>



More information about the kernel-team mailing list