ACK: [PATCH][F/Unstable] UBUNTU: [Config] Turn off CONFIG_RT_GROUP_SCHED everywhere
Colin Ian King
colin.king at canonical.com
Thu May 7 16:37:01 UTC 2020
On 07/05/2020 17:27, Seth Forshee wrote:
> BugLink: https://bugs.launchpad.net/bugs/1875665
>
> We enabled this option for some docker features, leaving it
> disabled in lowlatency, but we are getting reports of regressions
> with the generic kernel too. Some more digging on this option
> reveals that it's fairly specialized and likely requires
> workload-specific configuration and tuning to be of much use.
> It doesn't seem to make sense for a general-purpose kernel, so
> turn it back off in all of our kernels.
>
> Signed-off-by: Seth Forshee <seth.forshee at canonical.com>
> ---
> debian.master/config/amd64/config.flavour.generic | 1 -
> debian.master/config/amd64/config.flavour.lowlatency | 1 -
> debian.master/config/annotations | 7 +++----
> debian.master/config/arm64/config.common.arm64 | 1 -
> debian.master/config/armhf/config.common.armhf | 1 -
> debian.master/config/config.common.ubuntu | 1 +
> debian.master/config/i386/config.common.i386 | 1 -
> debian.master/config/ppc64el/config.common.ppc64el | 1 -
> debian.master/config/s390x/config.common.s390x | 1 -
> 9 files changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/debian.master/config/amd64/config.flavour.generic b/debian.master/config/amd64/config.flavour.generic
> index cc5ca64ba034..d1662374ea94 100644
> --- a/debian.master/config/amd64/config.flavour.generic
> +++ b/debian.master/config/amd64/config.flavour.generic
> @@ -8,4 +8,3 @@ CONFIG_HZ_250=y
> # CONFIG_LATENCYTOP is not set
> # CONFIG_PREEMPT is not set
> CONFIG_PREEMPT_VOLUNTARY=y
> -CONFIG_RT_GROUP_SCHED=y
> diff --git a/debian.master/config/amd64/config.flavour.lowlatency b/debian.master/config/amd64/config.flavour.lowlatency
> index 5f438aac9f49..814348dc984b 100644
> --- a/debian.master/config/amd64/config.flavour.lowlatency
> +++ b/debian.master/config/amd64/config.flavour.lowlatency
> @@ -8,4 +8,3 @@ CONFIG_IRQ_FORCED_THREADING_DEFAULT=y
> CONFIG_LATENCYTOP=y
> CONFIG_PREEMPT=y
> # CONFIG_PREEMPT_VOLUNTARY is not set
> -# CONFIG_RT_GROUP_SCHED is not set
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index dd6481141e9f..69d9887ce4c7 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -10390,11 +10390,10 @@ CONFIG_CGROUP_DEBUG policy<{'amd64': 'n', 'arm64': '
> CONFIG_CGROUP_SCHED policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> CONFIG_FAIR_GROUP_SCHED policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> CONFIG_CFS_BANDWIDTH policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> -CONFIG_RT_GROUP_SCHED policy<{'amd64-generic': 'y', 'amd64-lowlatency': 'n', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> +CONFIG_RT_GROUP_SCHED policy<{'amd64': 'n', 'arm64': 'n', 'armhf': 'n', 'i386': 'n', 'ppc64el': 'n', 's390x': 'n'}>
> CONFIG_UCLAMP_TASK_GROUP policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y'}>
> -
> -CONFIG_RT_GROUP_SCHED note<LP#1284731>
> -CONFIG_RT_GROUP_SCHED note<LP#1873315>
> +#
> +CONFIG_RT_GROUP_SCHED mark <ENFORCED> note<LP#1284731> note<LP#1873315> note<LP#1875665>
>
> # Menu: General setup >> IRQ subsystem
> CONFIG_IRQ_FORCED_THREADING_DEFAULT policy<{'amd64-generic': 'n', 'amd64-lowlatency': 'y', 'arm64': 'n', 'armhf': 'n', 'i386-generic': 'n', 'i386-lowlatency': 'y', 'ppc64el': 'n'}>
> diff --git a/debian.master/config/arm64/config.common.arm64 b/debian.master/config/arm64/config.common.arm64
> index 065a0af8c2df..af9d355db654 100644
> --- a/debian.master/config/arm64/config.common.arm64
> +++ b/debian.master/config/arm64/config.common.arm64
> @@ -505,7 +505,6 @@ CONFIG_RPMSG_VIRTIO=m
> CONFIG_RTC_DRV_PCF8523=m
> CONFIG_RTC_DRV_PL031=m
> CONFIG_RTC_DRV_TWL4030=m
> -CONFIG_RT_GROUP_SCHED=y
> CONFIG_S2IO=m
> CONFIG_SATA_AHCI_PLATFORM=m
> CONFIG_SCHED_SMT=y
> diff --git a/debian.master/config/armhf/config.common.armhf b/debian.master/config/armhf/config.common.armhf
> index 5b3e923157b3..ed4d48d79036 100644
> --- a/debian.master/config/armhf/config.common.armhf
> +++ b/debian.master/config/armhf/config.common.armhf
> @@ -482,7 +482,6 @@ CONFIG_RPMSG_VIRTIO=m
> CONFIG_RTC_DRV_CMOS=m
> CONFIG_RTC_DRV_PL031=y
> CONFIG_RTC_DRV_TWL4030=y
> -CONFIG_RT_GROUP_SCHED=y
> CONFIG_S2IO=m
> CONFIG_SATA_AHCI_PLATFORM=y
> # CONFIG_SCHED_SMT is not set
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index f502f2bdfa07..9c52bf524ff5 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -8291,6 +8291,7 @@ CONFIG_RTW88_DEBUG=y
> CONFIG_RTW88_DEBUGFS=y
> CONFIG_RTW88_PCI=m
> # CONFIG_RTW88_REGD_USER_REG_HINTS is not set
> +# CONFIG_RT_GROUP_SCHED is not set
> CONFIG_RT_MUTEXES=y
> CONFIG_RUNTIME_TESTING_MENU=y
> CONFIG_RWSEM_SPIN_ON_OWNER=y
> diff --git a/debian.master/config/i386/config.common.i386 b/debian.master/config/i386/config.common.i386
> index d5fb1d3dbd03..150b9e14147a 100644
> --- a/debian.master/config/i386/config.common.i386
> +++ b/debian.master/config/i386/config.common.i386
> @@ -480,7 +480,6 @@ CONFIG_ROMFS_FS=m
> CONFIG_RPMSG_VIRTIO=m
> CONFIG_RTC_DRV_CMOS=y
> CONFIG_RTC_DRV_PCF8523=m
> -CONFIG_RT_GROUP_SCHED=y
> CONFIG_S2IO=m
> CONFIG_SATA_AHCI_PLATFORM=m
> CONFIG_SCHED_SMT=y
> diff --git a/debian.master/config/ppc64el/config.common.ppc64el b/debian.master/config/ppc64el/config.common.ppc64el
> index c590267e3eb8..e3c13275ffc9 100644
> --- a/debian.master/config/ppc64el/config.common.ppc64el
> +++ b/debian.master/config/ppc64el/config.common.ppc64el
> @@ -486,7 +486,6 @@ CONFIG_RPMSG_VIRTIO=m
> CONFIG_RTC_DRV_CMOS=m
> CONFIG_RTC_DRV_PCF8523=m
> CONFIG_RTC_DRV_TWL4030=m
> -CONFIG_RT_GROUP_SCHED=y
> CONFIG_S2IO=m
> CONFIG_SATA_AHCI_PLATFORM=m
> CONFIG_SCHED_SMT=y
> diff --git a/debian.master/config/s390x/config.common.s390x b/debian.master/config/s390x/config.common.s390x
> index 9c8bb6be7ca1..6573f80165b1 100644
> --- a/debian.master/config/s390x/config.common.s390x
> +++ b/debian.master/config/s390x/config.common.s390x
> @@ -444,7 +444,6 @@ CONFIG_RCU_CPU_STALL_TIMEOUT=21
> # CONFIG_RMI4_CORE is not set
> # CONFIG_ROMFS_FS is not set
> # CONFIG_RPMSG_VIRTIO is not set
> -CONFIG_RT_GROUP_SCHED=y
> # CONFIG_S2IO is not set
> CONFIG_SCHED_SMT=y
> # CONFIG_SCSI_3W_9XXX is not set
>
This seems like the most pragmatic solution.
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the kernel-team
mailing list