ACK: [B][SRU][PATCH 0/1] Mark reuseport_bpf_numa as skip if not supported

Sultan Alsawaf sultan.alsawaf at canonical.com
Mon Mar 30 18:50:36 UTC 2020


Yay, a testing fix! \o/

Acked-by: Sultan Alsawaf <sultan.alsawaf at canonical.com>

On Mon, Mar 16, 2020 at 11:26:49AM +0800, Po-Hsu Lin wrote:
> == SRU Justification ==
> The reuseport_bpf_numa test in net category from ubuntu_kernel_selftests
> will fail on i386 systems with:
>   selftests: reuseport_bpf_numa
>   ========================================
>   not ok 1..3 selftests: reuseport_bpf_numa [FAIL]
> 
> If you run it directly, you will see the test is simply not supported.
>   $ sudo ./reuseport_bpf_numa
>   ./reuseport_bpf_numa: no numa api support: Function not implemented
> 
> == Fix ==
> * 1a2b80ec (selftests: net: reuseport_bpf_numa: don't fail if no numa
>  support)
> 
> We have this patch in newer kernel from D, and we don't run this test
> on Xenial so only Bionic needs this patch.
> 
> == Test ==
> Tested on a Bionic i386 node and it works as expected.
>   selftests: reuseport_bpf_numa
>   ========================================
>   1..0 # Skipped: no numa api support
>   ok 1..3 selftests: reuseport_bpf_numa [PASS]
> 
> == Regression Potential ==
> Low, trival change to testing tool itself.
> 
> Anders Roxell (1):
>   selftests: net: reuseport_bpf_numa: don't fail if no numa support
> 
>  tools/testing/selftests/net/reuseport_bpf_numa.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list