ACK: [SRU][OEM-OSP1-B][PATCH 0/2] All PS/2 ports on PS/2 Serial add-in bracket are not working after S3

Sultan Alsawaf sultan.alsawaf at canonical.com
Mon Mar 30 18:42:16 UTC 2020


Acked-by: Sultan Alsawaf <sultan.alsawaf at canonical.com>

On Mon, Mar 16, 2020 at 05:27:45PM +0800, You-Sheng Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1866734
> 
> [Impact]
> PS/2 ports on PS/2 Serial add-in card do not work after S3.
> 
> [Fix]
> The i8042 controller selftest fails while resuming, adding retry fix
> this issue.
> 
> [Test]
> Verified on the target machine, the ps/2 keyboard keeps working after S3
> test 30 times.
> 
> [Regression Potential]
> Low, there is a retry logic in controller selftest, but it returns
> directly if it fails to communicate with the controller. This commit
> make it retry 5 times before return fails.
> 
> [Misc]
> This revert a previous solution and add a rewritten one to preserve
> fault tolerance as the original drive code does.
> 
> You-Sheng Yang (2):
>   Revert "UBUNTU: SAUCE: Input: i8042 - Fix the selftest retry logic"
>   Input: i8042 - fix the selftest retry logic
> 
>  drivers/input/serio/i8042.c | 22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)
> 
> -- 
> 2.25.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list